From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Adding new schemas to nxml-mode Date: Thu, 22 Feb 2024 16:13:49 +0100 Message-ID: <25D87170-E120-4779-A84C-DF527D59EE71@secure.kjonigsen.net> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_7E9F448D-F08A-4E69-90A0-75EC5119CE8F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20279"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Ergus via Emacs development discussions." , Stefan Monnier To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 22 16:15:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdAn9-0004y2-Al for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Feb 2024 16:15:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdAm6-000658-4K; Thu, 22 Feb 2024 10:14:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdAm2-00064q-5n for emacs-devel@gnu.org; Thu, 22 Feb 2024 10:14:10 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdAlz-0005j3-Nq for emacs-devel@gnu.org; Thu, 22 Feb 2024 10:14:09 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E71B85C00A2; Thu, 22 Feb 2024 10:14:03 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Feb 2024 10:14:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708614843; x=1708701243; bh=49/LlA08VSX3KySe4J9ZX0+C+8xHbhXtWB976sisB5I=; b= HOYp6zJA/Xa4ckQYPPAAcSlIWawDhlhisRcJbDNn0xm6w+ISISQGwD1DEqOXNiCT 5vzofBPjopGODr5LOozOryiPa8vF+CJELIFZrjqXw+Zl1X1GFvBbvhEloAMUeW/h oFddogR2BwrU1HCk1b2kpjyRqDPzIQu8uwVNaxLuB+zL2Yp6OS7c+dkk8QI7HwF1 uNZoD+k0cmcCiFjVbezu/c8uuonN0BmcXbnRC4b8oPhD/biKNvfrhvvNJFxmgeuX 5jtVsjzTEMycY3M8GAdegStrf22oLK9xqOVLdv/axWeJ3t+CoXuuQwS1o8UK0u7M 34hzbiRPeqWCdbuTEVW+Sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708614843; x=1708701243; bh=49/LlA08VSX3KySe4J9ZX0+C+8xH bhXtWB976sisB5I=; b=mGdoeUjb/RaiOjzENVoIe+smXiBhH99Y2kxic/ZxhkeK uB6j/5k18uGS+TGlsAnj4pgumA/FSuTnB5TPUJqo781cmo+fSx/+hTyUf8KsR4LK YS6ZiSm40E1MNsBl34k/AnHrTPaxyAmeQVvUmER8yxLJrU89kaWK58sV3JLU/APu oj1QkOIasB/dSt9VjYZ++1HPgcvNFcmL6orx2BsbT3LXgpscxaL0mg5l47K+G+HT mt4lzNFy+7sRinYt2qmvFzpb52HBVgdO/WAFDMeaaocA9BtZVY8vGJjCwn4i2XqE OEjeh+1y8LrB7iESlMrmW2Qvqy6wtjQiFQ4OAbU0ng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeggdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhkfgtggfuffgjvefvfhfosegrtdhmrehhtdejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeehteehudetgfelteefgeetvedttdeg ueduledtiefgueehheffteelieevleeikeenucffohhmrghinhepohhfrdhnvghtpdhmoh guvghrnhdrnhgvthdpshhuphgvrhhsvgguvghsrdhnvghtnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrd hkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Feb 2024 10:14:02 -0500 (EST) In-Reply-To: X-Mailer: Apple Mail (2.3774.200.91.1.1) Received-SPF: pass client-ip=66.111.4.25; envelope-from=jostein@secure.kjonigsen.net; helo=out1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316454 Archived-At: --Apple-Mail=_7E9F448D-F08A-4E69-90A0-75EC5119CE8F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 21 Feb 2024, at 04:01, Stefan Kangas = wrote: >=20 >> Basically as a minimum make sure it works for more people than just = me. >=20 > What happens if it doesn't "work" in this context? Can it hurt or is = it > just an extra feature that they won't benefit from? In terms of =E2=80=9Cworking" I would consider the following: * The appropriate schemas are activated for the appropriate and expected = files. * The schemas, when activated, do not create warnings for correctly = formatted XML-files (according to that schema). In terms of NOT working, I would consider the following: * A schema is activated for a file which it is not appropriate for. * A schema, when activated for an appropriate file-type, flags correctly = formatted XML-elements within that file as erroneous. > - I think this should also come with updates to etc/schemas/README > describing the copyright and legal status of these new schemas. > See that file to get an idea of what's needed. I didn't know about that one. Will look into it! > - Does "Dotnet" also include "Mono" (or some other free software > replacement)? If yes, I think the commit message should say so > explicitly, so that we mention both but advertise mainly the free > version. I.e. it should say "Mono/Dotnet" rather than "Dotnet/Mono". Not going to go for a technical deep dive here, but in short: - .NET Framework was a closed-source Windows only development platform = created by Microsoft - Mono is a open-source cross-platform reimplementation of .NET = Framework Today when one refers to .NET when typically refers to the =E2=80=9Cnew=E2= =80=9D modern .NET project (with no =E2=80=9Cframework=E2=80=9D suffix), = which is both open-source and cross-platform. Modern .NET supersedes = .NET Framework, and in many ways Mono as well. While all file-types covered by schemas submitted here are = relevant/applicable to all those three development platforms, as they = all work on the same type of source-files and build-systems=E2=80=A6 I = would argue that the =E2=80=9Cmain=E2=80=9D development target these = days for any developer working on up to date tooling is going to be = .NET, not Mono. As such, I think just referring to it as dotnet is = appropriate. > - Should this be called out in NEWS? It could. I have no opinion on how =E2=80=9Cbig=E2=80=9D a = feature/change has to be before it=E2=80=99s considered newsworthy. I=E2=80=99ll let more seasoned Emacs-contributors decide that, if = that=E2=80=99s OK. > - (This should also have a proper ChangeLog in the commit message, of > course.) I thought I added a pretty decent one in my commit=E2=80=A6 Was that not = included in the patch? Or do you mean adding it to a ChangeLog file of some sort? If so, which = one? =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen= --Apple-Mail=_7E9F448D-F08A-4E69-90A0-75EC5119CE8F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8


On 21 Feb 2024, at 04:01, Stefan = Kangas <stefankangas@gmail.com> = wrote:

Basically as a = minimum make sure it works for more people than just = me.

What happens if it doesn't "work" in this = context?  Can it hurt or is it
just an extra feature that they = won't benefit from?

In = terms of =E2=80=9Cworking" I would consider the = following:

* The appropriate schemas are = activated for the appropriate and expected files.
* The = schemas, when activated, do not create warnings for correctly formatted = XML-files (according to that schema).

In terms = of NOT working, I would consider the = following:

* A schema is activated for a file = which it is not appropriate for.
* A schema, when activated = for an appropriate file-type, flags correctly formatted XML-elements = within that file as erroneous.

- I think this should also come with updates to = etc/schemas/README
 describing the copyright and legal status = of these new schemas.
 See that file to get an idea of what's = needed.

I didn't know = about that one. Will look into it!

- Does "Dotnet" also include "Mono" (or some = other free software
 replacement)?  If yes, I think the = commit message should say so
 explicitly, so that we mention = both but advertise mainly the free
 version.  I.e. it = should say "Mono/Dotnet" rather than = "Dotnet/Mono".

Not going = to go for a technical deep dive here, but in = short:

- .NET Framework was a closed-source = Windows only development platform created by Microsoft
- Mono = is a open-source cross-platform reimplementation of .NET = Framework

Today when one refers to .NET when = typically refers to the =E2=80=9Cnew=E2=80=9D modern .NET project (with = no =E2=80=9Cframework=E2=80=9D suffix), which is both open-source and = cross-platform. Modern .NET supersedes .NET Framework, and in many ways = Mono as well.

While all file-types covered by = schemas submitted here are relevant/applicable to all those three = development platforms, as they all work on the same type of source-files = and build-systems=E2=80=A6 I would argue that the =E2=80=9Cmain=E2=80=9D = development target these days for any developer working on up to date = tooling is going to be .NET, not Mono. As such, I think just referring = to it as dotnet is appropriate.

- Should this be called out in = NEWS?

It could. I have = no opinion on how =E2=80=9Cbig=E2=80=9D a feature/change has to be = before it=E2=80=99s considered = newsworthy.

I=E2=80=99ll let more seasoned = Emacs-contributors decide that, if that=E2=80=99s = OK.

- = (This should also have a proper ChangeLog in the commit message, of
=  course.)

I = thought I added a pretty decent one in my commit=E2=80=A6 Was that not = included in the patch?

Or do you mean adding it to a = ChangeLog file of some sort? If so, which = one?


=E2=80=94
Kind = Regards
Jostein Kj=C3=B8nigsen
= --Apple-Mail=_7E9F448D-F08A-4E69-90A0-75EC5119CE8F--