From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Date: Wed, 14 Dec 2022 14:34:04 -0800 Message-ID: <25CBAC04-CD42-4C36-A331-653021DEBA0F@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3983"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Theodor Thornhill , Eli Zaretskii , jostein@kjonigsen.net, 59897@debbugs.gnu.org, 59897-done@debbugs.gnu.org To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 14 23:35:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5aLN-0000kz-2l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Dec 2022 23:35:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5aL9-0006dD-JU; Wed, 14 Dec 2022 17:35:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5aL8-0006d0-Kl for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 17:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5aL8-0003YI-9Q for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 17:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5aL8-0001ZA-42 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 17:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2022 22:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59897-submit@debbugs.gnu.org id=B59897.16710572565996 (code B ref 59897); Wed, 14 Dec 2022 22:35:02 +0000 Original-Received: (at 59897) by debbugs.gnu.org; 14 Dec 2022 22:34:16 +0000 Original-Received: from localhost ([127.0.0.1]:41968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5aKO-0001Yd-BQ for submit@debbugs.gnu.org; Wed, 14 Dec 2022 17:34:16 -0500 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:36768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5aKK-0001YR-Ab; Wed, 14 Dec 2022 17:34:14 -0500 Original-Received: by mail-pg1-f175.google.com with SMTP id s196so2978315pgs.3; Wed, 14 Dec 2022 14:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7avqEnwQnYDiOprPgNko18mMNv6EvDsUfFjjlJO86V8=; b=fkjHH6FBG8V2AOFci0k4UmVqoI+8y1r8amP0BBwn30N862PLBFk/FF94hKANbQrPhZ O/3mmcG9xx+WShgTny6KVUkpMohgQW9uZ6H/bvWgIXUxCaDzn3hlX7KqPjaCPNcaBUiJ 2xFplxFZp1UwPAzse3fDD3ScbPVi1ZuaWKpNXwBDLKnc9oyvkAT04AyIc41u/mlbKUGn S9vB5junnbyIRkD+lZ0dm6u90+pj3K70oBjbXeSgt510/mgQJn4Gj6uMzEECHx2XnCaM vvG2YMdcJzCYRf0ps33mdC7Gxc0945h9WNJ1NtXw97rb8XOZJLmIq1/LvBJL1MUky7GB z8lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7avqEnwQnYDiOprPgNko18mMNv6EvDsUfFjjlJO86V8=; b=XjIlKn8wDQiOiICuDDro/UFxMjQQeBkCWDH7t9QXOxJMLHmahu51GOssYtpTcR/c5o PxmDnNzYabqPRi+R3rkZSj8MA7FjvKTdSrl5N2ck7AuhpO7I81ThFfsuzP5iImVWTx01 JJ2+5EOhrloNMXs0j0G5qjXoJ6ppW3r4mryOAtiegJ/IuNQHAKkSfBjcFdRcOYSWwKQb 7W+JKbkED4kd/Z9U0Q3PVvMsWgKeQHo88ctWfZYuXejtlvyOtIWVzmGU6ygAPxKPm9km 8FAC3jzbs2yVLITjAmk0j1SSuKJeyV5rWk9foFPyfl3MZQJvKRYOxzh7UxhZVmMmCEX3 /1Ig== X-Gm-Message-State: ANoB5plp36ABCDUyTRSaUtp/v01UYflMJZKLzASDEDzDo4S31YmGBC6U ec2LTx+BDOjeDh/DvLbXUEw= X-Google-Smtp-Source: AA0mqf6FQdYUhgBGVS0Jx+ELL8h9UNr4UyX7WnplZ9b/CD69WSWbGU5scIILIZla38AmpQvRSrAVMQ== X-Received: by 2002:aa7:8147:0:b0:56e:9868:52fc with SMTP id d7-20020aa78147000000b0056e986852fcmr23527677pfn.25.1671057246261; Wed, 14 Dec 2022 14:34:06 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z3-20020aa79483000000b0056d73ef41fdsm355992pfk.75.2022.12.14.14.34.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 14:34:05 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251009 Archived-At: > On Dec 14, 2022, at 1:45 PM, Jostein Kj=C3=B8nigsen = wrote: >=20 > Hey Yuan.=20 >=20 > =46rom what I can see you pushed Teos patch and not mine? >=20 > = https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-29&id=3D647b= 6a8099f414e5a7b162efd3658e174064dfe7emacs.git - Emacs source repository > savannah.gnu.org > >=20 >=20 > In the email discussion earlier we unanymously decided on that for = technical reasons my patch was more appropriate for this particular bug, = and it also fixed another fontification bug.=20 >=20 > What do we do now? Should we revert this commit and apply mine = instead? >=20 > Sorry for all the =E2=80=9Cnoise=E2=80=9D, but this gets hard to = follow up for all of us when latency between input and output gets too = long, and then we end up writing emails like this, instead of writing = good code to improve emacs and our new major-modes.=20 >=20 > If this could get cleaned up, installed properly, confirmed -and- = pushed at the same time, it would be easier for me to verify that the = right patch was put in place, and then I wouldn=E2=80=99t nag you for = weeks end for what is really just 4 lines of code ;) Ahhhhh sorry! I reverted the old commit and applied yours, you should = now see it. I=E2=80=99ll try to process these patches more promptly in = the future. Yuan=