From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Noah Peart <noah.v.peart@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
70362@debbugs.gnu.org
Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode
Date: Sun, 14 Apr 2024 16:32:43 -0700 [thread overview]
Message-ID: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com> (raw)
In-Reply-To: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@mail.gmail.com>
Dmitry Gutov <dmitry@gutov.dev> writes:
> On 13/04/2024 10:40, Noah Peart wrote:
>> I put it at level 3 following the conventions in other treesit modes
>> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
>> builtins at level 3.
>> But, I haven't done a full census of the ts modes so there might be
>> variability.
>
> SGTM. If classic major modes highlight a thing (and they do that for
> built-ins), we usually put it in the default highlighting for ts modes
> as well (meaning level 3 or lower).
Right. And the patch looks good to me.
Yuan
next prev parent reply other threads:[~2024-04-14 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 5:47 bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Noah Peart
2024-04-13 7:23 ` Eli Zaretskii
2024-04-13 7:40 ` Noah Peart
2024-04-13 12:16 ` Dmitry Gutov
2024-04-14 23:32 ` Yuan Fu [this message]
2024-04-16 0:44 ` Randy Taylor
2024-04-18 10:32 ` Eli Zaretskii
2024-04-18 13:44 ` Randy Taylor
2024-04-18 14:15 ` Eli Zaretskii
2024-04-18 10:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com \
--to=casouri@gmail.com \
--cc=70362@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.