From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: New unwind-protect byte-compiler warning Date: Fri, 7 Apr 2023 19:40:03 +0200 Message-ID: <25A5C1A9-0321-43B6-A359-5659DB79F5F8@gmail.com> References: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27110"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 07 21:07:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkrQa-0006vy-8Y for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Apr 2023 21:07:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkrPy-0001XP-D6; Fri, 07 Apr 2023 15:06:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkq4G-0003XL-P1 for emacs-devel@gnu.org; Fri, 07 Apr 2023 13:40:09 -0400 Original-Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkq4F-0005f5-17 for emacs-devel@gnu.org; Fri, 07 Apr 2023 13:40:08 -0400 Original-Received: by mail-lj1-x22f.google.com with SMTP id x20so44133218ljq.9 for ; Fri, 07 Apr 2023 10:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680889204; x=1683481204; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=GtmVWVXN4jiLY3kfQKX2zC7pzyYkRKHBzUKdP1RH9vI=; b=TQh5nz0yGKSQsjHTX0i63acUBXCHvM/wndit8KBwPyUZe7wcuMq/feQpROl/Bb5AYX Xk4LnVOU/xeCJw05klQ1NDFChxKvhF9DgAO0jOjxW5/LVUOI2lpblAD3b39CarvQFqey LUqfUMkxHit8yPin/ZETtQFUzgU8Yx2m78uhwX/2gAUNa42ZnTyWkVVgiNEBYEFCSPdH 5EMn5dBWVaNjfZvoKB1VAjRKvpOu3dWqA9MrwGh4bZ2uK13kqBNTVJ01mdDiEe9e414j S3x+8zRBI8FPE/QHHiOvGRkalsXYGVg7teW4QrmToyLMOniGnLa73EWvonXcKc98f5fa U/eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680889204; x=1683481204; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GtmVWVXN4jiLY3kfQKX2zC7pzyYkRKHBzUKdP1RH9vI=; b=eLDx+IsKR9Vxul8pXWO38wHfY4hGVrF6K8Fr3F6PnzZLNH9FT9EMn7dvEeSqfdmUgl G0RV1iMTHWoBamraxLjeQ/1opfLMkS89XOjKJAPflji18kjN9ibTKN33VXs+1gFrpLdn 7ZQPffjEY7WNodX3ZhaV7U88lOoQl28D/Zw0nPY0M9PSW1BZA8ifHUPWnaBmfquQZYFs 1xt67MaGZk30Y7spMbvBcPVero7QU1vEmQd9Rx/W6TSFfYqkYqYrNiOojgfxbaXe1aj7 MmsjEER2wyqAhuMG/pOFq4c1QJC8V6lozii6lkjyhRPZge1t4W4/jRyfVhT53qdlJtLm lFJw== X-Gm-Message-State: AAQBX9dVjaLV7ANIW3edzHNdlKEruByjbh+iR3iJTX7sEMh4IHA2U6FU JKgd9y2hACH9BUIHlS/IvujiJfL7Czs= X-Google-Smtp-Source: AKy350aqAuYb1I81lePUSGeLoOwBjoBFHynRVVfbVZg4y3FoqfpiAXAueOJI5Aa1k0swrQQEZxhLSg== X-Received: by 2002:a2e:6e0e:0:b0:29d:ce75:5d06 with SMTP id j14-20020a2e6e0e000000b0029dce755d06mr861572ljc.32.1680889204439; Fri, 07 Apr 2023 10:40:04 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id p24-20020a2ea418000000b0029bd4365c95sm918365ljn.87.2023.04.07.10.40.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2023 10:40:03 -0700 (PDT) In-Reply-To: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::22f; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x22f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 07 Apr 2023 15:06:36 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305162 Archived-At: 30 mars 2023 kl. 10.01 skrev Mattias Engdeg=C3=A5rd = : > This will eventually leave some warnings claimed by no-one for me to = take on, which will be done in a conservative way, maybe after a week. This has now been done. Two warnings remain but Basil has promising = patches for them in the bug tracker. Also thanks to Michael who fixed a few tramp-related warnings. Michael, = here's a bonus for you uncovered by an experimental compiler change = (that I didn't end up applying): > (defun tramp-sshfs-handle-insert-file-contents > (filename &optional visit beg end replace) > "Like `insert-file-contents' for Tramp files." > (setq filename (expand-file-name filename)) > (let (signal-hook-function result) > (unwind-protect > (setq result > (insert-file-contents > (tramp-fuse-local-file-name filename) visit beg end = replace)) > (when visit (setq buffer-file-name filename)) > (cons filename (cdr result))))) The last unwind form seems to expect its value to be used, but it is = really discarded. Perhaps it's just a misplaced bracket?