From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.devel Subject: Re: Proposal to add Popper to ELPA Date: Tue, 5 Sep 2023 17:27:08 -0300 Message-ID: <255bb831-2309-764a-bb23-087ab267437b@gmail.com> References: <874jk8ef0k.fsf@gmail.com> <87y1hkcygb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: emacs-devel@gnu.org To: Philip Kaludercic , Karthik Chikmagalur Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 05 22:28:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdceW-0003FD-8u for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Sep 2023 22:28:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdcdr-0003Ly-8u; Tue, 05 Sep 2023 16:27:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdcdp-0003Lf-7F for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:27:17 -0400 Original-Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdcdm-000636-LH for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:27:16 -0400 Original-Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1c8e9d75ce1so1707833fac.3 for ; Tue, 05 Sep 2023 13:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693945633; x=1694550433; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lrtMJiO5cUd0SGf11A6dWF5nu41zpeLej9t0eBvYn+Q=; b=inuCRqr6lLxPhq1brP1kkOGobChcI4Q+otYT+VXysPgY+b+vFe27gSpEOvM3MVsHkF GeJHKYddL/GSWHJg1MjM7r/5YMKX2hICWz/4ywVzr9xpd/54rh4wNlnBrCj16ZlwGwzo wPtzl+CBlG/rxeYxDYmajTZSZUTLCD6g4swN30xWJ2rB0GLUlApGm9T5VspnxX892shv hlcF7Atk9Go/TVm1NMrWF3dhziSNdVF1dRplRLjljPXdbASspfhphFqx8r+deo9Oj+eX lDLp63DU25kS8Xs62qSwAQDeLKU8J88EP6vNU9vT51snxUfy5zGCOPr6TaWhWoDl1ZXh 2wKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693945633; x=1694550433; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lrtMJiO5cUd0SGf11A6dWF5nu41zpeLej9t0eBvYn+Q=; b=aYvzqQzPRFrSP/tHiBZhUdt9kgnkEzU9WX3Zp4MHAK06hEj0orpdVq8gdzKLn3QXd1 vsxMzWroLp6fJBilMHGcebgThkAP1MJwYBHzlUazPiSmsBgEJ+voPboCgX6EsTj1vdSs JTsQ3V5U4YyfSGJpzogkalh0lmwuQJQGYKCOjq9lIWOKu7TJwfKKhldA/M4/jSz0bcHJ m8Z/RdaNjmDZFJWn+k7DtQKobaHuObxqRMG9hQXjJkobjxdtXu+U/ucGFCJVzL12JugK ciZR8x1GtqNTWuJuOeHO95U7cmL8Y368OcA2KLAYqgBBv4QObIkVZOFHHAnEiRmSHn/k TMjA== X-Gm-Message-State: AOJu0Yy20OwZ4xZ8xFxGErAos83U9Bh3reABpAzITsgrF6t0HbQ8dgpq tRVrJFCOMCDUjI9rNvkawOTD9Ff9KdE= X-Google-Smtp-Source: AGHT+IHekrI/NueOj3vCcmKVdcg7kzsJd8PrJ63HNxrwip3jW1JTJ+R6Lxf6vObW9x+nEZNeK4vdAA== X-Received: by 2002:a05:6870:41d3:b0:1d0:d357:c526 with SMTP id z19-20020a05687041d300b001d0d357c526mr14794299oac.11.1693945633219; Tue, 05 Sep 2023 13:27:13 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id du49-20020a0568703a3100b001c8f250820esm6900444oab.48.2023.09.05.13.27.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 13:27:12 -0700 (PDT) Content-Language: en-US In-Reply-To: <87y1hkcygb.fsf@posteo.net> Received-SPF: pass client-ip=2001:4860:4864:20::2a; envelope-from=maurooaranda@gmail.com; helo=mail-oa1-x2a.google.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.473, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310152 Archived-At: On 5/9/23 14:38, Philip Kaludercic wrote: > Karthik Chikmagalur writes: > >> I would like to add my package Popper to GNU ELPA. >> >> URL: https://github.com/karthink/popper > > Here are a few changes I would propose to make. Haven't tested it, so > take it with a grain of salt: > - :type '(restricted-sexp :match-alternatives (stringp symbolp functionp consp)) > - :group 'popper) > + :type '(repeat (string :tag "Regular Expression") > + (symbol :tag "Major Mode") > + (function :tag "Predicate Function") > + ;; What is the consp in (restricted-sexp :match-alternatives (stringp symbolp functionp consp))? > + )) The different alternatives should be inside a choice: :type '(repeat (choice (string :tag "Regular Expression") (symbol :tag "Major Mode") (function :tag "Predicate Function")) > (defcustom popper-mode-line-position 0 > "Position in mode-line to place `popper-mode-line'." > - :type 'integer > - :group 'popper) > + :type 'natnum) IIUC, the package requires Emacs 26.1, and the natnum widget wasn't available back then. Does Compat have it?