Re: Proposal to add Popper to ELPA

[Mauro Aranda <maurooaranda@gmail.com>]

On 5/9/23 14:38, Philip Kaludercic wrote:
 > Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
 >
 >> I would like to add my package Popper to GNU ELPA.
 >>
 >> URL: https://github.com/karthink/popper
 >
 > Here are a few changes I would propose to make.  Haven't tested it, so
 > take it with a grain of salt:
 > -  :type '(restricted-sexp :match-alternatives (stringp symbolp 
functionp consp))
 > -  :group 'popper)
 > +  :type '(repeat (string :tag "Regular Expression")
 > +		 (symbol :tag "Major Mode")
 > +		 (function :tag "Predicate Function")
 > +		 ;; What is the consp in (restricted-sexp :match-alternatives 
(stringp symbolp functionp consp))?
 > +		 ))

The different alternatives should be inside a choice:
:type '(repeat (choice (string :tag "Regular Expression")
                        (symbol :tag "Major Mode")
                        (function :tag "Predicate Function"))

 >   (defcustom popper-mode-line-position 0
 >     "Position in mode-line to place `popper-mode-line'."
 > -  :type 'integer
 > -  :group 'popper)
 > +  :type 'natnum)

IIUC, the package requires Emacs 26.1, and the natnum widget wasn't
available back then.  Does Compat have it?