From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance Date: Thu, 5 Jan 2023 11:31:08 +0100 Message-ID: <255D9E93-422C-4A43-9876-751FDB8E61DB@acm.org> References: <875yfyebi0.fsf@posteo.net> <87a6331xts.fsf@posteo.net> <1119f0ff-aacf-b41e-e7f7-b0a00132b35f@yandex.ru> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 58950@debbugs.gnu.org, Dmitry Gutov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 11:32:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDNY2-0001Yk-VR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 11:32:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDNXi-00026q-NP; Thu, 05 Jan 2023 05:32:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDNXY-00023j-IS for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 05:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDNXW-0004YT-L5 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 05:32:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDNXW-0005yD-8W for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 05:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 10:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58950-submit@debbugs.gnu.org id=B58950.167291467722891 (code B ref 58950); Thu, 05 Jan 2023 10:32:02 +0000 Original-Received: (at 58950) by debbugs.gnu.org; 5 Jan 2023 10:31:17 +0000 Original-Received: from localhost ([127.0.0.1]:50348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDNWm-0005x9-MN for submit@debbugs.gnu.org; Thu, 05 Jan 2023 05:31:17 -0500 Original-Received: from mail70c50.megamailservers.eu ([91.136.10.80]:33190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDNWk-0005x0-Eq for 58950@debbugs.gnu.org; Thu, 05 Jan 2023 05:31:15 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1672914672; bh=10gajO31+7HlqlSmLk5jjXk2FTSvn/kDXLPjbq+BH5Y=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=UHrhLXrUh5q/IB46IcODywkqRyMtaNgY1hBTrrWL5ALzl6Qdy0AHJbxzIx6Q+Pi1Q unEc4jqFydCcA/BR8bYzrUHru7Bm3CS/olXfeDDxYyT68yYJYkRZKSliew6rEpJGL2 eNQ5YUEIyA2LxIvDtE0FghnkdvlVJ7QVgxlJmddA= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 305AV95q080441; Thu, 5 Jan 2023 10:31:11 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F25.63B6A6F0.006C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252588 Archived-At: 5 jan. 2023 kl. 05.31 skrev Stefan Monnier : > I don't much like the kind of mini-language we invented for > `buffer-match-p`. I'd prefer we just used plain old ELisp for that. Yes, I sort of wondered whether we were going full Greenspun here. We = haven't added many embedded languages into our embedded language lately. The usual DSL worthiness criteria: - more expressive than plain code for the domain - potential for significantly better performance - better error-checking, statically or dynamically - structured editing etc, don't really seem to be met here but I'm not deeply familiar with = the problem and perhaps the author could make a better case for it.