From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan Moringen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add notifications.el Date: Fri, 11 Jun 2010 11:27:03 +0200 Message-ID: <25565_1276248424_ZZh0128x1soJE.00_1276248423.7761.280.camel@azurit.TechFak.Uni-Bielefeld.DE> References: <13588_1276211690_ZZh01350LoUj0.00_1276211773.5476.15.camel@localhost.localdomain> <3277_1276238795_o5B6kZER023748_87aar22hj1.fsf@keller.adm.naquadah.org> <1183_1276241420_ZZh0127gAT2R9.00_1276241419.7761.245.camel@azurit.TechFak.Uni-Bielefeld.DE> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: dough.gmane.org 1276270160 8281 80.91.229.12 (11 Jun 2010 15:29:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Jun 2010 15:29:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Julien Danjou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 11 17:29:18 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ON6AP-0007jm-AJ for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 17:29:10 +0200 Original-Received: from localhost ([127.0.0.1]:40370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON6AN-0005BB-J0 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 11:29:07 -0400 Original-Received: from [140.186.70.92] (port=51032 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON0W3-0007ou-Uz for emacs-devel@gnu.org; Fri, 11 Jun 2010 05:27:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ON0W2-0004qp-Bq for emacs-devel@gnu.org; Fri, 11 Jun 2010 05:27:07 -0400 Original-Received: from mux1-unibi-smtp.hrz.uni-bielefeld.de ([129.70.204.65]:51238) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON0W2-0004qk-6J for emacs-devel@gnu.org; Fri, 11 Jun 2010 05:27:06 -0400 Original-Received: from pmxchannel-daemon.mux1-unibi-smtp.hrz.uni-bielefeld.de by mux1-unibi-smtp.hrz.uni-bielefeld.de (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) id <0L3U00I00FL4SK00@mux1-unibi-smtp.hrz.uni-bielefeld.de> for emacs-devel@gnu.org; Fri, 11 Jun 2010 11:27:04 +0200 (CEST) Original-Received: from [129.70.143.11] ([129.70.143.11]) by mux1-unibi-smtp.hrz.uni-bielefeld.de (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPPSA id <0L3U007N4FL3U7E0@mux1-unibi-smtp.hrz.uni-bielefeld.de>; Fri, 11 Jun 2010 11:27:04 +0200 (CEST) In-reply-to: X-Mailer: Evolution 2.22.3.1 X-EnvFrom: jmoringen@uni-bielefeld.de X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2010.6.11.91814, pmx8 X-Connecting-IP: 129.70.143.11 X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Mailman-Approved-At: Fri, 11 Jun 2010 11:28:43 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125743 Archived-At: > > Maybe it's a bug in the notification daemon? It happened for every > > notification I produced from Emacs on this machine. The notifications > > also varied significantly. So in case of an error it wouldn't exactly be > > a corner case which makes this possibility seem unlikely. > > Does it happend with the ones made from notify-send? I don't have notify-send on this system, but here is an example where evolution caused the notification: method call sender=:1.764 -> dest=org.freedesktop.Notifications path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify string "evolution-mail-notification" uint32 0 string "mail-unread" string "New email" string "You have received 1 new message in Inbox." array [ ] array [ dict entry( string "y" variant int32 1188 ) dict entry( string "xdisplay" variant string ":0.0" ) dict entry( string "urgency" variant byte 1 ) dict entry( string "x" variant int32 1313 ) ] int32 -1 method return sender=:1.19 -> dest=:1.764 reply_serial=1011 uint32 258 signal sender=:1.19 -> dest=:1.764 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=NotificationClosed uint32 258 The NotificationClosed signal has no reason, just like with Emacs. > Anyhow, nothing allows you to work-around the bug by putting reason > &optional. Anybody can emit a wrong formatted signal on the dbus, even > with dbus-send. Based on that, any D-Bus bad formatted signal/method > call will raise an error. > > Bad that's like calling a Lisp function with requires 2 arguments with > only 1. It raises an error because you call it badly. I don't see why we > wouldn't do the thing even if the function is called via D-Bus. > > But yes if, you don't want to know about bugged implementation, you use > &optional in every dbus signal/method function you will use (even > outside notifications.el). I agree, working around other people's bugs is undesirable. However, since this system is a Ubuntu LTS version, the problem could potentially affect many users. Kind regards, Jan