bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[Drew Adams]

I doubt this will help much, but just in case it does -
I got this backtrace when I clicked the `X' in a frame showing
*scratch*.  There were two frames showing *scratch*, and I clicked the
"X" in each.  Dunno which one the error was raised for.

Debugger entered--Lisp error: (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)
  frame-selected-window(#<dead frame *scratch* 0b54c8d8>)
  menu-bar-non-minibuffer-window-p()
  redisplay_internal\ \(C\ function\)()


This was using my setup, but I don't think I have anything particular
that should affect this.  Dunno how to repro it, either with my setup or
from emacs -Q.

Feel free to close the bug if this info doesn't help at all.  I have no
more info about this.

In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[Eli Zaretskii]

> Date: Thu, 29 Jan 2015 09:29:46 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> I doubt this will help much, but just in case it does -
> I got this backtrace when I clicked the `X' in a frame showing
> *scratch*.  There were two frames showing *scratch*, and I clicked the
> "X" in each.  Dunno which one the error was raised for.
> 
> Debugger entered--Lisp error: (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)
>   frame-selected-window(#<dead frame *scratch* 0b54c8d8>)
>   menu-bar-non-minibuffer-window-p()
>   redisplay_internal\ \(C\ function\)()

Any idea how come redisplay got to call
menu-bar-non-minibuffer-window-p?

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[Drew Adams]

> Any idea how come redisplay got to call
> menu-bar-non-minibuffer-window-p?

I do have this in my setup - these are the only occurrences of
that function in my code:

;; Add for Emacs < 22.  Rename item otherwise.
(define-key menu-bar-file-menu [new-file]
  '(menu-item "New File..." find-file
    :enable (or (not (fboundp 'menu-bar-non-minibuffer-window-p))
             (menu-bar-non-minibuffer-window-p))
    :help "Create and edit a new file"))

(define-key-after menu-bar-file-menu [new-directory]
  '(menu-item "New Directory..." menu-bar-create-directory
    :enable (or (not (fboundp 'menu-bar-non-minibuffer-window-p))
             (menu-bar-non-minibuffer-window-p))
    :help "Create a directory")
  'new-file)

I realize that :enable will cause that code to be run during
redisplay.  Probably this is the culprit code, but I have never
see that error before (and this code has been there a long time).

So maybe it's just a one-off thing.

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[Eli Zaretskii]

> Date: Thu, 29 Jan 2015 09:46:35 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 19728@debbugs.gnu.org
> 
> > Any idea how come redisplay got to call
> > menu-bar-non-minibuffer-window-p?
> 
> I do have this in my setup - these are the only occurrences of
> that function in my code:
> 
> ;; Add for Emacs < 22.  Rename item otherwise.
> (define-key menu-bar-file-menu [new-file]
>   '(menu-item "New File..." find-file
>     :enable (or (not (fboundp 'menu-bar-non-minibuffer-window-p))
>              (menu-bar-non-minibuffer-window-p))
>     :help "Create and edit a new file"))
> 
> (define-key-after menu-bar-file-menu [new-directory]
>   '(menu-item "New Directory..." menu-bar-create-directory
>     :enable (or (not (fboundp 'menu-bar-non-minibuffer-window-p))
>              (menu-bar-non-minibuffer-window-p))
>     :help "Create a directory")
>   'new-file)
> 
> I realize that :enable will cause that code to be run during
> redisplay.  Probably this is the culprit code, but I have never
> see that error before (and this code has been there a long time).
> 
> So maybe it's just a one-off thing.

Or maybe menu-bar-non-minibuffer-window-p should protect itself from
such calamities.  Martin, what do you think?

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[martin rudalics]

 > Or maybe menu-bar-non-minibuffer-window-p should protect itself from
 > such calamities.  Martin, what do you think?

It should.  Just like `menu-bar-menu-frame-live-and-visible-p' does.

martin

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[Eli Zaretskii]

> Date: Sat, 31 Jan 2015 15:22:02 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 19728@debbugs.gnu.org
> 
>  > Or maybe menu-bar-non-minibuffer-window-p should protect itself from
>  > such calamities.  Martin, what do you think?
> 
> It should.  Just like `menu-bar-menu-frame-live-and-visible-p' does.

Could you please take care of this bug, then?  TIA.

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[martin rudalics]

 > Could you please take care of this bug, then?  TIA.

See commit 017a03a..618931b  emacs-24 -> emacs-24

martin

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[Eli Zaretskii]

> Date: Sat, 31 Jan 2015 19:46:08 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: drew.adams@oracle.com, 19728@debbugs.gnu.org
> 
>  > Could you please take care of this bug, then?  TIA.
> 
> See commit 017a03a..618931b  emacs-24 -> emacs-24

Thanks!

bug#19728: 25.0.50; (wrong-type-argument frame-live-p #<dead frame *scratch* 0b54c8d8>)

[martin rudalics]

>> See commit 017a03a..618931b  emacs-24 -> emacs-24
>
> Thanks!

Bug closed.

Thanks for the report, martin