From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-clock-select-task bugfix (XEmacs incompatibility) Date: Wed, 2 Dec 2009 06:41:32 +0100 Message-ID: <252E914A-E305-4841-B39E-470700D355F6@gmail.com> References: <87y6lmwj8o.fsf@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFhyA-0006vS-5J for emacs-orgmode@gnu.org; Wed, 02 Dec 2009 00:41:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFhy5-0006v0-Ao for emacs-orgmode@gnu.org; Wed, 02 Dec 2009 00:41:41 -0500 Received: from [199.232.76.173] (port=44913 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFhy5-0006ux-48 for emacs-orgmode@gnu.org; Wed, 02 Dec 2009 00:41:37 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:42099) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFhy4-0002LL-NQ for emacs-orgmode@gnu.org; Wed, 02 Dec 2009 00:41:36 -0500 Received: by bwz7 with SMTP id 7so3721696bwz.26 for ; Tue, 01 Dec 2009 21:41:35 -0800 (PST) In-Reply-To: <87y6lmwj8o.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Richard KLINDA Cc: emacs-orgmode@gnu.org Hi Richard, I don't see why this would be necessary? Under what circumstances does this fail? - Carsten On Dec 1, 2009, at 9:07 PM, Richard KLINDA wrote: > See attached simple patch. > > From 795d529d622f509f47c2bf17a0139fbe1659cc5f Mon Sep 17 00:00:00 2001 > From: Richard Klinda > Date: Tue, 1 Dec 2009 21:03:39 +0100 > Subject: [PATCH] org-clock: org-clock-select-task bugfix (XEmacs) > > --- > lisp/org-clock.el | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/lisp/org-clock.el b/lisp/org-clock.el > index 56dbab5..87017fc 100644 > --- a/lisp/org-clock.el > +++ b/lisp/org-clock.el > @@ -344,6 +344,10 @@ of a different task.") > (org-fit-window-to-buffer) > (message (or prompt "Select task for clocking:")) > (setq rpl (read-char-exclusive)) > + (when (featurep 'xemacs) > + ;; in XEmacs read-char-exclusive returns character, instead > of > + ;; ascii value > + (setq rpl (char-octet rpl))) > (cond > ((eq rpl ?q) nil) > ((eq rpl ?x) nil) > -- > 1.6.2.1 > > > -- > Richard > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten