From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Okamsn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73431: Add `setf` support for `stream.el` in ELPA Date: Wed, 25 Sep 2024 00:17:50 +0000 Message-ID: <2522160a-761c-4f23-a9c7-4740b49681f1@protonmail.com> References: <827cc7fc-10be-4b93-bd67-f275193e5d84@protonmail.com> <87ikultl1v.fsf@posteo.net> Reply-To: Okamsn Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5654"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Nicolas Petton , 73431@debbugs.gnu.org To: Stefan Monnier , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 25 02:18:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stFk8-0001LJ-Ab for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Sep 2024 02:18:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stFjs-0004RV-3p; Tue, 24 Sep 2024 20:18:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stFjp-0004Ql-Q1 for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 20:18:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stFjp-0005k0-He for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 20:18:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=Qj1RcB4f6ON7NDz3JKyHei97IJNEWNEt5BdCVDpBiIo=; b=kioP1Z7tLzhPaUxoAHJnm0nRa2fa6emtjKazuTSV+adnHkBMVP8Y6q2mjOTZmV1et7b1gNKl6rUXXrHx1GaFoi0abnl6XQbfBJXDw35LlppNSk41azp+bjmVwGICbASJCwqrZFnWjqxFjH207noSIJFsWd/BmB6o4UmClJHP8xHjuCM4IUl4VdTXGF5HbJXhjFqOhNpkLtVa7ROzlzbf0yBa9xmQsgNegIJGoHpO6NCpoIWsFjDA7++5xVwKtBsDSBg5WEpPtGdiHS8PBpvvN7z9CpFevIuEyyaz/D9op2qhtJzBi5pFKP45n/ds70/s2OpMAqKkx3lLpFvU1lO7fQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1stFkE-0005DJ-5p for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 20:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Okamsn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2024 00:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73431 X-GNU-PR-Package: emacs Original-Received: via spool by 73431-submit@debbugs.gnu.org id=B73431.172722351119943 (code B ref 73431); Wed, 25 Sep 2024 00:19:02 +0000 Original-Received: (at 73431) by debbugs.gnu.org; 25 Sep 2024 00:18:31 +0000 Original-Received: from localhost ([127.0.0.1]:52406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stFji-0005BZ-MC for submit@debbugs.gnu.org; Tue, 24 Sep 2024 20:18:31 -0400 Original-Received: from mail-0301.mail-europe.com ([188.165.51.139]:48350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stFjf-0005B0-My for 73431@debbugs.gnu.org; Tue, 24 Sep 2024 20:18:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1727223475; x=1727482675; bh=Qj1RcB4f6ON7NDz3JKyHei97IJNEWNEt5BdCVDpBiIo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=sf/LV3HnxCK4RBuof9ADEQeKFU2d7NS6Oj2wZJ1zFdd0X/H8Ogsvw0w4S6tTxps6R xQbRyG0c7CQMERKtVRy5LuVnTGhvNGgOf861HWDNYEDPEk7hcz7iD7n1QVgoQp+S8A vtQWii94pGdLGzUMaltCt88gmFV3TNMxoTvBJCSXvVYAynpG8GIRA0q4Uaj3Vf88QM yZ0YSsljJttjITknDY6DBsayDFe4x++V+p0NNSxzL8EYZK9zEkE80eo2gNqrN9liTE C/wAOoLHBO5oy2xBVDyamWerM/Q6SMhtGoJamNyHXZukU1jtwplvoFfHFhE3FcG1bN KnhIOXGLJm4kQ== In-Reply-To: Feedback-ID: 25935600:user:proton X-Pm-Message-ID: d90dc5346070275463cb2631e5fcf1e648b1267b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292368 Archived-At: Stefan Monnier wrote: >>> +(defun \(setf\ stream-first\) (store stream) >>> + "Set the first element of STREAM to value STORE." >>> + (if (stream-empty-p stream) >>> + (error "Cannot set first element of empty stream: %s" stream) >>> + (setcar (stream--force stream) store))) >> >> I am not sure what the preferred practice to define generalised setters >> is. In gv.el everything is defined using `gv-define-simple-setter' or >> `gv-define-setter', which /feels/ more robust? I believe that Stefan >> (as the author or gv.el) might be able to explain if this is so or not. >=20 > Defining \(setf\ FOO\) looks fine to me =F0=9F=99=82 > I'm not sure we want to make streams mutable, OTOH. > Is there a known use-case for it? >=20 >=20 > Stefan >=20 Hello, Currently, using `(setf (seq-elt STREAM 0) VAL)` silently fails, because=20 it treats the stream as a list, breaking the stream. On the desire for mutability, there is the included macro `stream-pop`. My use case is mainly consistency. I am currently cleaning up support=20 for destructuring generic sequences with generalized variables in my=20 package, which is how I noticed the silent failure for streams. I have=20 found streams useful for iterating over sub-sequences of vectors, like=20 what `cl-maplist` does with lists. Thank you.