all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, help-gnu-emacs@gnu.org
Subject: Re: How to test for native JSON support?
Date: Tue, 4 May 2021 17:30:28 +0300	[thread overview]
Message-ID: <2510de19-5b28-06d3-9a7b-631c9e506578@yandex.ru> (raw)
In-Reply-To: <83v97y4my9.fsf@gnu.org>

On 04.05.2021 17:01, Eli Zaretskii wrote:

> Feel free to suggest a patch,

Like this?

diff --git a/src/json.c b/src/json.c
index 3f1d27ad7f..ece057ae41 100644
--- a/src/json.c
+++ b/src/json.c
@@ -596,8 +596,7 @@ DEFUN ("json-serialize", Fjson_serialize, 
Sjson_serialize, 1, MANY,
      }
    if (!json_initialized)
      {
-      message1 ("jansson library not found");
-      return Qnil;
+      Fsignal (Qerror, list1 (build_unibyte_string ("jansson library 
not found")));
      }
  #endif

@@ -707,8 +706,7 @@ DEFUN ("json-insert", Fjson_insert, Sjson_insert, 1, 
MANY,
      }
    if (!json_initialized)
      {
-      message1 ("jansson library not found");
-      return Qnil;
+      Fsignal (Qerror, list1 (build_unibyte_string ("jansson library 
not found")));
      }
  #endif

@@ -966,8 +964,7 @@ DEFUN ("json-parse-string", Fjson_parse_string, 
Sjson_parse_string, 1, MANY,
      }
    if (!json_initialized)
      {
-      message1 ("jansson library not found");
-      return Qnil;
+      Fsignal (Qerror, list1 (build_unibyte_string ("jansson library 
not found")));
      }
  #endif

@@ -1065,8 +1062,7 @@ DEFUN ("json-parse-buffer", Fjson_parse_buffer, 
Sjson_parse_buffer,
      }
    if (!json_initialized)
      {
-      message1 ("jansson library not found");
-      return Qnil;
+      Fsignal (Qerror, list1 (build_unibyte_string ("jansson library 
not found")));
      }
  #endif


> and let's see if you will be able to
> convince The Powers That Be.

Praise the Powers! I pray they be convinced!



  reply	other threads:[~2021-05-04 14:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02 12:09 How to test for native JSON support? Joost Kremers
2021-05-03  0:20 ` Nikolay Kudryavtsev
2021-05-03  8:21   ` Joost Kremers
2021-05-03 14:38     ` Nikolay Kudryavtsev
2021-05-03 18:59       ` Joost Kremers
2021-05-03 19:42   ` Dmitry Gutov
2021-05-03 22:33     ` Nikolay Kudryavtsev
2021-05-03 22:39       ` Dmitry Gutov
2021-05-04 11:40       ` Tim Landscheidt
2021-05-04 12:16         ` Eli Zaretskii
2021-05-04 12:29           ` Joost Kremers
2021-05-04 12:50             ` Eli Zaretskii
2021-05-04 13:06               ` Joost Kremers
2021-05-04 13:17               ` Dmitry Gutov
2021-05-04 14:01                 ` Eli Zaretskii
2021-05-04 14:30                   ` Dmitry Gutov [this message]
2021-05-04 14:32                     ` Philipp Stephani
2021-05-04 14:41                       ` Dmitry Gutov
2021-05-04 15:16                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2510de19-5b28-06d3-9a7b-631c9e506578@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.