From: Jim Porter <jporterbugs@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 57241@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Dario Gjorgjevski <dario.gjorgjevski@gmail.com>,
control@debbugs.gnu.org
Subject: bug#57241: Commit b87400c broke master
Date: Wed, 31 Aug 2022 22:55:56 -0700 [thread overview]
Message-ID: <24b72887-f72e-b7a2-12a3-faec7c21afe4@gmail.com> (raw)
In-Reply-To: <27E3403F-B4E5-415E-8A02-5ED04960C406@acm.org>
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
On 8/30/2022 7:55 AM, Mattias Engdegård wrote:
> reopen 57241
> stop
>
> For the test-custom-opts failure.
The attached patch fixes this for me. Does this seem like a reasonable
way to go about it?
[-- Attachment #2: 0001-Under-no-X-builds-allow-any-value-for-fringe-bitmap-.patch --]
[-- Type: text/plain, Size: 1148 bytes --]
From 86152743c478c7aca95ce9de9edfd78d29718faa Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Wed, 31 Aug 2022 22:52:34 -0700
Subject: [PATCH] Under no-X builds, allow any value for 'fringe-bitmap'
options
* lisp/cus-edit (fringe-bitmap): Always match under no-X.
---
lisp/cus-edit.el | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index d3768766be..2229b6bdb7 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -4298,7 +4298,12 @@ 'fringe-bitmap
"A Lisp fringe bitmap name."
:format "%v"
:tag "Fringe bitmap"
- :match (lambda (_widget value) (fringe-bitmap-p value))
+ :match (lambda (_widget value)
+ ;; In no-X builds, allow anything. This ensures that
+ ;; customizations set on a with-X build aren't considered
+ ;; invalid under no-X.
+ (or (not (boundp 'fringe-bitmaps))
+ (fringe-bitmap-p value)))
:completions (apply-partially #'completion-table-with-predicate
obarray #'fringe-bitmap-p 'strict)
:prompt-match 'fringe-bitmap-p
--
2.25.1
next prev parent reply other threads:[~2022-09-01 5:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 12:39 bug#57241: Commit b87400c broke master Dario Gjorgjevski
2022-08-16 12:55 ` Eli Zaretskii
2022-08-16 13:07 ` Dario Gjorgjevski
2022-08-16 13:16 ` Eli Zaretskii
2022-08-16 13:23 ` Dario Gjorgjevski
2022-08-16 13:42 ` Eli Zaretskii
2022-08-16 18:51 ` Jim Porter
2022-08-26 19:06 ` Mattias Engdegård
2022-08-30 14:55 ` Mattias Engdegård
2022-09-01 5:55 ` Jim Porter [this message]
2022-09-01 8:04 ` Mattias Engdegård
2022-09-02 1:36 ` Jim Porter
2022-09-02 11:43 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24b72887-f72e-b7a2-12a3-faec7c21afe4@gmail.com \
--to=jporterbugs@gmail.com \
--cc=57241@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=dario.gjorgjevski@gmail.com \
--cc=eliz@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.