From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15906: 24.3.50; Rename `highlight-*' functions Date: Fri, 15 Nov 2013 10:31:24 -0800 (PST) Message-ID: <24a86bb5-f82f-4211-b0a7-dc40ddd60470@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1384540417 12030 80.91.229.3 (15 Nov 2013 18:33:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Nov 2013 18:33:37 +0000 (UTC) To: 15906@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 19:33:35 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VhOCs-0006jC-Ng for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2013 19:33:26 +0100 Original-Received: from localhost ([::1]:33375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhOCs-0005OX-8p for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2013 13:33:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhOCf-0005NT-0t for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:33:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhOCU-0007dV-VM for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:33:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhOCU-0007dR-SZ for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VhOCU-00039o-Ha for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2013 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15906 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138454032412061 (code B ref -1); Fri, 15 Nov 2013 18:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Nov 2013 18:32:04 +0000 Original-Received: from localhost ([127.0.0.1]:56202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhOBY-00038T-7R for submit@debbugs.gnu.org; Fri, 15 Nov 2013 13:32:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58695) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhOBV-00037y-Jq for submit@debbugs.gnu.org; Fri, 15 Nov 2013 13:32:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhOBG-00070S-4g for submit@debbugs.gnu.org; Fri, 15 Nov 2013 13:31:56 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:47298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhOBG-00070N-1z for submit@debbugs.gnu.org; Fri, 15 Nov 2013 13:31:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhOB7-0004KV-Fn for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:31:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhOAy-0006q2-SQ for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:31:37 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:46609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhOAy-0006po-M6 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 13:31:28 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rAFIVQWG021249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 15 Nov 2013 18:31:27 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAFIVQr4007363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 15 Nov 2013 18:31:26 GMT Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAFIVQeV007351 for ; Fri, 15 Nov 2013 18:31:26 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80613 Archived-At: The prefix `highlight-' should not be used for something as specific as `hi-lock' highlighting or highlighting to show changes. There are lots of different kinds of highlighting in Emacs. And third party libraries provide many more ways. The latter are requested by convention to use a library prefix. Hi Lock is one kind of highlighting, and quite particular. The "lock" part of its name is significant - it differentiates this highlighting from other highlighting, and it should be present in the function names. These are the functions to rename, with suggested renamings: highlight-lines-matching-regexp -> hi-lock-lines-matching-regexp highlight-phrase -> hi-lock-phrase highlight-regexp -> hi-lock-regexp highlight-changes-mode -> hilit-changes-mode highlight-changes-next-change -> hilit-changes-next-change highlight-changes-previous-change -> hilit-changes-previous-change highlight-changes-remove-highlight -> hilit-changes-remove-highlight highlight-changes-rotate-faces -> hilit-changes-rotate-faces highlight-changes-visible-mode -> hilit-changes-visible-mode highlight-compare-buffers -> hilit-compare-buffers highlight-compare-with-file -> hilit-compare-with-file An alternative for the `hilit-' functions would be to use `changes-' as the prefix. The result is clearer and shorter names, and it puts up front what the highlighting is about: showing changes: changes-highlight-mode changes-highlight-next changes-highlight-previous changes-remove-highlight changes-rotate-faces changes-visible-mode changes-compare-buffers changes-compare-with-file (No need for "highlight" at all in half of these names.) In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-11-12 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1'