From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: mouse-face highlighting broken? Date: Thu, 7 May 2009 09:53:34 -0400 Message-ID: <24F12CAB-6F76-492A-B9A4-312CF0F5AEAB@gmail.com> References: <87iqke6xx3.fsf@cyd.mit.edu> <357AADAB-5EEF-456A-9C7B-D851376EB118@gmail.com> <006401c9ce73$57448900$c2b22382@us.oracle.com> <874ovxwmei.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1241704439 13861 80.91.229.12 (7 May 2009 13:53:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 May 2009 13:53:59 +0000 (UTC) Cc: Chong Yidong , Adrian Robert , Drew Adams , Emacs-Devel devel To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 07 15:53:52 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M242p-00032b-FR for ged-emacs-devel@m.gmane.org; Thu, 07 May 2009 15:53:51 +0200 Original-Received: from localhost ([127.0.0.1]:50796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M242o-000173-Mp for ged-emacs-devel@m.gmane.org; Thu, 07 May 2009 09:53:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M242k-00016o-67 for emacs-devel@gnu.org; Thu, 07 May 2009 09:53:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M242f-00016c-ID for emacs-devel@gnu.org; Thu, 07 May 2009 09:53:45 -0400 Original-Received: from [199.232.76.173] (port=37810 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M242f-00016Z-Fc for emacs-devel@gnu.org; Thu, 07 May 2009 09:53:41 -0400 Original-Received: from mail-bw0-f161.google.com ([209.85.218.161]:35013) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M242e-0004vT-Mh for emacs-devel@gnu.org; Thu, 07 May 2009 09:53:41 -0400 Original-Received: by bwz5 with SMTP id 5so816612bwz.42 for ; Thu, 07 May 2009 06:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=Ve29aVYQaJYVYl7RFhsFg+FH+XAxgJWMW+KuJYyLDhw=; b=OtDvkIaikuYEvumT5BroQHCjHp2G7BAKaGafadfw0xaNGzI3RQmavBISJnxqc39AK+ 49pOWWfsfgR4CMVDI2p/64nchNdWf+fwzXef5dmYtrTaabqBl8t/ka3idiolQ2ud5FbN J+G3/Y4HJ3HnKi/Kz4CRScLolaZqv+Yfnp9gM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=d9zXA88vj1LT140ywgLPEZumwQ8qRuwax8KSsIJ48XR/pOZqs+KgAN8jsT19aNe8lk U9p4P/wajSuTfKJ+mGwW6Ar1fE9wyFQrirLVe22SYXrJ7YZJaDuSAS36JG65WEiLY5E0 qJ8FXkWlRy3hL5N3sAqMZGLRKLC7RdX3uMcu0= Original-Received: by 10.103.160.10 with SMTP id m10mr1303179muo.50.1241704419357; Thu, 07 May 2009 06:53:39 -0700 (PDT) Original-Received: from ?192.168.1.42? (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) by mx.google.com with ESMTPS id j9sm266414mue.21.2009.05.07.06.53.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 07 May 2009 06:53:38 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110754 Archived-At: On May 7, 2009, at 2:29 AM, YAMAMOTO Mitsuharu wrote: > The > other terms consolidate the mouse face handling into one function > x_set_mouse_face_gc rather than scattering it into 3 (the proposed > change makes it 5) places. Also, this uniformity among different > terms makes it easier for other terms to catch up with xterm.c > changes. Yes, some refactoring is definitely in order after the release. Cleaner code would be nice, things like ns_tmp_flags are just confusing. Also, better comments would make things much easier, particularly in xdisp.c.