From: Carsten Dominik <carsten.dominik@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-orgmode@gnu.org
Subject: Re: org-fill-paragraph leaves point at end of table
Date: Mon, 25 Feb 2013 10:21:49 +0100 [thread overview]
Message-ID: <24BE6F65-CD8B-4964-AA13-DB61F21F402D@gmail.com> (raw)
In-Reply-To: <87hal0u5bi.fsf@gmail.com>
On 25 feb. 2013, at 10:10, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Calling `org-fill-paragraph' inside a table leaves point at the end of
>> the table, for reasons that are totally unclear to me.
>>
>> I've tested this with up-to-date org and emacs -Q, so I'm hoping it's
>> reproducible. I edebugged org-fill-paragraph, and it appears to do the
>> right thing, going from the save-excursion to the cond to the org-table
>> cond statement, and there calling `org-table-align'. That works
>> correctly, but stepping forward you come to the end of the enclosing
>> `save-excursion', and emerging from `save-excursion' puts point at the
>> end of the table -- precisely what it's not supposed to do!
>>
>> I made a minimum sexp to reproduce the relevant bits of
>> org-fill-paragraph:
>>
>> #+BEGIN_SRC emacs-lisp
>> (save-excursion
>> (let ((element (org-element-at-point)))
>> (case (org-element-type element)
>> (table-row (org-table-align) t))))
>> #+END_SRC
>>
>> Putting point in a table and eval'ing that also leaves point at the end
>> of the table. I tried using (call-interactively 'org-table-align) and it
>> did the same thing.
>>
>> I'm baffled, particularly as it doesn't do this for any other element
>> type. Any clever ideas? M-q after a bit of typing is already stuck in my
>> fingers, and this bit of strangeness doesn't set the mark, so editing
>> long tables is a pain...
>
> `org-table-align' inserts a whole new table and removes completely the
> previous one. This confuses `save-excursion' which doesn't recognize any
> familiar location anymore.
>
> I've pushed a fix for it. All filling tests pass, but if you notice
> anything suspicious, please signal it.
I do not expect problems, because you now fall back onto org-table-align without any save-excursion around it, AFAICS. org-table-align remembers line number and table row number and restores them, so this should work.
- Carsten
next prev parent reply other threads:[~2013-02-25 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 3:04 org-fill-paragraph leaves point at end of table Eric Abrahamsen
2013-02-25 9:10 ` Nicolas Goaziou
2013-02-25 9:21 ` Carsten Dominik [this message]
2013-02-25 10:12 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24BE6F65-CD8B-4964-AA13-DB61F21F402D@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.