From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#37006: 27.0.50; garbage collection not happening after 26de2d42 Date: Sun, 11 Aug 2019 18:23:28 +0200 Message-ID: <24BB9DB5-D832-462F-A03C-5595A80B6973@acm.org> References: <5075406D-6DB8-4560-BB64-7198526FCF9F@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_D6DABFC1-0A66-4D5C-82F0-60D31AF39C10" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153708"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Paul Eggert , 37006@debbugs.gnu.org To: jrm@ftfl.ca Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 11 18:24:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwqdd-000dpY-Aj for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 18:24:09 +0200 Original-Received: from localhost ([::1]:40878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwqdb-0001l1-WB for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 12:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53499) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwqdW-0001ka-Vn for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 12:24:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwqdW-0006Kh-4Y for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 12:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36915) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwqdW-0006KZ-1q for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 12:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwqdV-0000VC-SE for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 12:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2019 16:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37006-submit@debbugs.gnu.org id=B37006.15655406231903 (code B ref 37006); Sun, 11 Aug 2019 16:24:01 +0000 Original-Received: (at 37006) by debbugs.gnu.org; 11 Aug 2019 16:23:43 +0000 Original-Received: from localhost ([127.0.0.1]:45736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwqdD-0000Ud-52 for submit@debbugs.gnu.org; Sun, 11 Aug 2019 12:23:43 -0400 Original-Received: from mail156c50.megamailservers.eu ([91.136.10.166]:46262 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwqdB-0000UV-N1 for 37006@debbugs.gnu.org; Sun, 11 Aug 2019 12:23:42 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1565540611; bh=8lBi61DL1i2QCkL+4PbqXBm9yFM3/3IKMkfdPftxsSQ=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=SFzWWBnhLOi50gecypJJQFHKuEckQiI+p6LxNVPXXG0UvOxvA0np33bWJMA7cmluH TSriDbwu8qwSSATyKdqNPAk0JqylmNUG4jI1ODr0ucUzk733XCl1IRJHd+Uu8jtvCp s9J5iN+S2jMK9fcVNj9VJt3nFuYjVcQL7ibO1vnY= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x7BGNTAJ018346; Sun, 11 Aug 2019 16:23:30 +0000 In-Reply-To: <5075406D-6DB8-4560-BB64-7198526FCF9F@acm.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020B.5D504103.0024, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=U6m889ju c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=M51BFTxLslgA:10 a=WtjGUeIEe98SbmMuVg0A:9 a=AmAs7HYEYo2_7xvh:21 a=i6Idrmfwgjngf_50:21 a=CjuIK1q_8ugA:10 a=kyAyQksBrJXqRUp9kFYA:9 a=B2y7HmGcmWMA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164890 Archived-At: --Apple-Mail=_D6DABFC1-0A66-4D5C-82F0-60D31AF39C10 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Observed on macOS as well. Reason: free_cons has the condition if (INT_ADD_WRAPV (consing_until_gc, sizeof *ptr, &consing_until_gc)) which will return true (overflow) if consing_until_gc is negative, which = is kind of defensible since sizeof is unsigned which causes the sum = (consing_until_gc + sizeof *ptr) to be a large unsigned number that = doesn't fit into consing_until_gc. Clang 10 defines __GNUC__ to 4 which causes intprops.h to not use = __builtin_add_overflow despite that being present and working. Casting the sizeof should fix it; patch attached. --Apple-Mail=_D6DABFC1-0A66-4D5C-82F0-60D31AF39C10 Content-Disposition: attachment; filename=0001-Avoid-unsigned-addend-in-overflow-check-bug-37006.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Avoid-unsigned-addend-in-overflow-check-bug-37006.patch" Content-Transfer-Encoding: quoted-printable =46rom=20f733339714cab022cbbdea06148795d452b183fe=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2011=20Aug=202019=2018:11:54=20+0200=0A= Subject:=20[PATCH]=20Avoid=20unsigned=20addend=20in=20overflow=20check=20= (bug#37006)=0A=0A*=20src/alloc.c=20(free_cons):=20Cast=20addend=20to=20= avoid=20spurious=20overflow=20when=0Aconsing_until_gc=20is=20negative.=0A= ---=0A=20src/alloc.c=20|=203=20++-=0A=201=20file=20changed,=202=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20a/src/alloc.c=20= b/src/alloc.c=0Aindex=205e089311a2..d416d32743=20100644=0A---=20= a/src/alloc.c=0A+++=20b/src/alloc.c=0A@@=20-2542,7=20+2542,8=20@@=20= free_cons=20(struct=20Lisp_Cons=20*ptr)=0A=20=20=20ptr->u.s.u.chain=20=3D=20= cons_free_list;=0A=20=20=20ptr->u.s.car=20=3D=20dead_object=20();=0A=20=20= =20cons_free_list=20=3D=20ptr;=0A-=20=20if=20(INT_ADD_WRAPV=20= (consing_until_gc,=20sizeof=20*ptr,=20&consing_until_gc))=0A+=20=20if=20= (INT_ADD_WRAPV=20(consing_until_gc,=20(object_ct)=20sizeof=20*ptr,=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= &consing_until_gc))=0A=20=20=20=20=20consing_until_gc=20=3D=20= OBJECT_CT_MAX;=0A=20=20=20gcstat.total_free_conses++;=0A=20}=0A--=20=0A= 2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_D6DABFC1-0A66-4D5C-82F0-60D31AF39C10--