From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs Subject: bug#50279: 28.0.50; ffap-file-finder customization no longer works Date: Mon, 30 Aug 2021 13:07:48 -0400 Message-ID: <24877.4196.703337.360137@orion.rgrjr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23779"; mail-complaints-to="usenet@ciao.gmane.io" To: 50279@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 30 19:08:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKkli-0005zS-D0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Aug 2021 19:08:22 +0200 Original-Received: from localhost ([::1]:40566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKklh-0000J3-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Aug 2021 13:08:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKklO-0000It-4y for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 13:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKklN-0008Ou-Tw for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 13:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKklN-0002iz-OA for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 13:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Aug 2021 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50279 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163034327610461 (code B ref -1); Mon, 30 Aug 2021 17:08:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Aug 2021 17:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:60163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKklI-0002ie-BA for submit@debbugs.gnu.org; Mon, 30 Aug 2021 13:07:56 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:43950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKklG-0002iW-3S for submit@debbugs.gnu.org; Mon, 30 Aug 2021 13:07:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKklF-0000AY-Va for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 13:07:53 -0400 Original-Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]:42982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKklE-0008Ds-2x for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 13:07:53 -0400 Original-Received: by mail-qt1-x832.google.com with SMTP id w17so2565514qta.9 for ; Mon, 30 Aug 2021 10:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rgrjr-com.20150623.gappssmtp.com; s=20150623; h=from:mime-version:content-transfer-encoding:message-id:date:to :subject; bh=V8qVz158F+9zPwTdh51E963j9soHhDiYzq5JDA2vz4Q=; b=x2WE+Wm7MfMnx3fBgDvl8W/1Jl/+l9zmdIVKM3LatYm5ugoKuxmGfyt4SeFTGmC68A 7R74DimbHaj2yotqtJKkjcxMUhV2Pbkqjo9aHEaPndYvEcNAWmR69jSfPxQ61cSfXXJ6 PGySxMDD5aWQMndGDuitSVd9LJzLHP/NX20yUToxI8+rwjeCX64LvySlfEriHerY+46a x/nh8xhWW7TdHLvuX27R8T/wV7gy22+DyeihJYdhvLx/D68SueDu7oZlVrAp9gc+V0IS ifzHlN/rc5yieM2pFVkA6VjGBgIle3TSTlmOEPLfUTNccH7TL/wp/4xUTD7WT1h5uPxN 7fTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:subject; bh=V8qVz158F+9zPwTdh51E963j9soHhDiYzq5JDA2vz4Q=; b=VAbSOuILvIr2uqe2E3XjMSxCdZ/V2Y/WFFDcFU2PpohY3htZ424WU04r7HIaTDrU7m 5YpSy6+1G4DYbtVvPZwByz25H+nMFiTsEjiDfUyYHWrgOXqrqXNnxo8RvIHNwm9ZsU4K PoaPo9KIF1LgfpQ0QUQ+A3eZNqaIwNPPDOKDb5BVobk3GqnM7TGdXt6XHOn3WCjeh47M tc95OHFoKPfp9fTRr+xs4Jt2+fVZHmmNa8seEAY6wLjGJvO96SEHPRgb4nlcmpdPvoT1 /EvvKw8uvgGuM8TYgeH2dPSheyT/yWF7U10Df2NHpD6DlO1fx31JaPRSVGv1dyX5Sb64 VBmA== X-Gm-Message-State: AOAM533Ft0v8JtrusA5kWZtPjF/x7F4MLpA6m900rEYwxINVCM6MsSRF ljIRzBffKWY4BSb+Nlen03cj5g7WHsKz2w== X-Google-Smtp-Source: ABdhPJzLVijsTalybbOKfBwmYWrp9JFSsiG6BXvoZ2bQsgIEqp0gIK7Z1tFPaXEYloG6O4xLgIKdRQ== X-Received: by 2002:a05:622a:1452:: with SMTP id v18mr5582269qtx.214.1630343270366; Mon, 30 Aug 2021 10:07:50 -0700 (PDT) Original-Received: from orion.rgrjr.com ([2601:19c:4600:3270:1eb7:2cff:fea9:e38b]) by smtp.gmail.com with ESMTPSA id 187sm11512262qke.32.2021.08.30.10.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 10:07:49 -0700 (PDT) X-Mailer: VM 7.19 under Emacs 28.0.50 Received-SPF: none client-ip=2607:f8b0:4864:20::832; envelope-from=rogers@rgrjr.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213035 Archived-At: I have a long-standing customization to ffap-file-finder which offers external applications depending on file extension that is broken by the following commit: commit 253b36bd40d1b342cdda09b0bee183788120f67e Author: dickmao Date: Tue Aug 3 12:02:48 2021 -0400 ffap ido accommodation Now that ffap-file-finder can be ido-find-file, the noninteractive portion of find-file-at-point cannot assume ffap-file-finder always takes an argument (ido-find-file does not). * lisp/ffap.el (find-file-at-point): Do not call ffap-file-finder. * test/lisp/ffap-tests.el (ffap-ido-mode): Test it. The essence of the change is that it does find-file at the critical point instead of funcalling ffap-file-finder. I assume that breaking such extensions was not the intent, as it is an incompatible change to a defcustom variable, and there is no associated NEWS entry. -- Bob Rogers http://www.rgrjr.com/