all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brennan Vincent <brennan@umanwizard.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61521@debbugs.gnu.org
Subject: bug#61521: "default" is now the first item returned from (font-faces), breaking various code.
Date: Wed, 15 Feb 2023 09:01:31 -0500	[thread overview]
Message-ID: <2485DA7C-3614-4182-BC29-7EFCF5C86A45@umanwizard.com> (raw)
In-Reply-To: <831qmrcch3.fsf@gnu.org>


> On Feb 15, 2023, at 07:58, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> 
>> 
>> Date: Tue, 14 Feb 2023 19:31:30 -0500
>> From: Brennan Vincent <brennan@umanwizard.com>
>> 
>> Various code seems to expect "default" to be the /last/ item in the list
>> returned by that function, not the first. For example, this comment in faces.el:
>> 
>>  ;; The `reverse' is so that `default' goes first.
>>  (dolist (face (nreverse (face-list)))
> 
> That comment is obsolete and needs to be changed (and the call to
> nreverse should perhaps be removed).

If the order returned by face-list is not guaranteed, then why does it do sorting at all?

>> Also, org-html-htmlize-generate-css does not work when default comes first in
>> the list (as it skips processing all fonts after default).
> 
> Isn't that a bug in that Org function?  It shouldn't rely on any
> particular order.

In that case, we can consider this bug report to relate to the broken Org function, which is how I initially discovered the face-list issue.






  reply	other threads:[~2023-02-15 14:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  0:31 bug#61521: "default" is now the first item returned from (font-faces), breaking various code Brennan Vincent
2023-02-15  0:52 ` Brennan Vincent
2023-02-15  1:00 ` Gregory Heytings
2023-02-15  1:06   ` Brennan Vincent
2023-02-15  9:00     ` Gregory Heytings
2023-02-15 13:43       ` Eli Zaretskii
2023-02-15 14:11         ` Gregory Heytings
2023-02-17 22:17           ` Kai Ma
2023-02-18  6:49             ` Eli Zaretskii
2023-02-18  6:54               ` Kai Ma
2023-02-18  7:40                 ` Eli Zaretskii
2023-02-15 12:58 ` Eli Zaretskii
2023-02-15 14:01   ` Brennan Vincent [this message]
2023-02-15 14:19     ` Gregory Heytings
2023-02-15 14:24     ` Eli Zaretskii
2023-02-15 16:19       ` Brennan Vincent
2023-02-17  8:29         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2485DA7C-3614-4182-BC29-7EFCF5C86A45@umanwizard.com \
    --to=brennan@umanwizard.com \
    --cc=61521@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.