From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: report-emacs-bug, flyspell Date: Thu, 12 Jun 2008 08:48:05 +0100 Message-ID: <24846EF2-8344-412F-8C46-41DA4E2AAC2A@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v924) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1213256906 18072 80.91.229.12 (12 Jun 2008 07:48:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Jun 2008 07:48:26 +0000 (UTC) To: Emacs-Devel devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 12 09:49:10 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K6hYT-0008Ge-7N for ged-emacs-devel@m.gmane.org; Thu, 12 Jun 2008 09:49:09 +0200 Original-Received: from localhost ([127.0.0.1]:59247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6hXf-0001rd-F3 for ged-emacs-devel@m.gmane.org; Thu, 12 Jun 2008 03:48:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6hXb-0001rO-6D for emacs-devel@gnu.org; Thu, 12 Jun 2008 03:48:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6hXY-0001oo-MC for emacs-devel@gnu.org; Thu, 12 Jun 2008 03:48:13 -0400 Original-Received: from [199.232.76.173] (port=40003 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6hXY-0001oi-IQ for emacs-devel@gnu.org; Thu, 12 Jun 2008 03:48:12 -0400 Original-Received: from ug-out-1314.google.com ([66.249.92.169]:3214) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K6hXW-00007F-4O for emacs-devel@gnu.org; Thu, 12 Jun 2008 03:48:11 -0400 Original-Received: by ug-out-1314.google.com with SMTP id l31so277072ugc.48 for ; Thu, 12 Jun 2008 00:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=347KD9uZH0n1ck3R59KO+GZ4LN98KpcBQ0bi00Mk3YI=; b=G4rvL7uFmcI38g+TULlSnxSpAkS15ku+FWfU+Pa8xEWbzuIW9oR9l5RCcQIOpY77mI 6R94xJeT6zfnNUNhW5HstnR9scE6e2vJrmZjQn5eLu824COEP7MT7ntSDaa9JSTbT7D6 bpGMcISbfmCFjx3sIQ7PqUZjqWntKRq4FZ38Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=ElGIxJCcQJCO7a89lFM0/d3sIt/3sRt0fctWq5vidFZv+HgwrZq20a5YhPE05c+26m RYYIJd59Mw1Mkrw/ju9BME3LRaM2HGeulvKHFktGkV55ZsNOh6grd2GJBqnSphg2S46k 22NCB3ixfTi/IZFk86zfVbGW4SxS6NSVQQ07I= Original-Received: by 10.67.40.6 with SMTP id s6mr2127716ugj.72.1213256888073; Thu, 12 Jun 2008 00:48:08 -0700 (PDT) Original-Received: from scarlett.lan ( [93.96.127.15]) by mx.google.com with ESMTPS id w28sm1470839uge.50.2008.06.12.00.48.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 12 Jun 2008 00:48:07 -0700 (PDT) X-Mailer: Apple Mail (2.924) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98996 Archived-At: When enabling flyspell in a buffer created by M-x report-emacs-bug, or when flyspell is generally enabled for all text modes with (add-hook 'text-mode-hook 'flyspell-mode), an error from within post-command- hook is thrown: `message-signature-separator' is void. The reason for that is that `mail-mode-flyspell-verify' wrongly assumes that `message-signature-separator' is defined. `report-emacs- bug' enables mail mode, but does not load `message'. A simple fix follows. *** lisp/textmodes/flyspell.el 06 Apr 2008 12:51:35 +0100 1.118.2.6 --- lisp/textmodes/flyspell.el 12 Jun 2008 08:45:05 +0100 *************** *** 296,306 **** "$") nil t) (point))) ! (signature-begin (save-excursion ! (goto-char (point-max)) ! (re-search-backward message-signature-separator ! nil t) ! (point)))) (cond ((< (point) header-end) (and (save-excursion (beginning-of-line) (looking-at "^Subject:")) --- 296,309 ---- "$") nil t) (point))) ! (signature-begin (if (not (boundp 'message-signature-separator)) ! (point-max) ! (save-excursion ! (goto-char (point-max)) ! (re-search-backward ! message-signature-separator ! nil t) ! (point))))) (cond ((< (point) header-end) (and (save-excursion (beginning-of-line) (looking-at "^Subject:"))