From: David Reitter <david.reitter@gmail.com>
To: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: report-emacs-bug, flyspell
Date: Thu, 12 Jun 2008 08:48:05 +0100 [thread overview]
Message-ID: <24846EF2-8344-412F-8C46-41DA4E2AAC2A@gmail.com> (raw)
When enabling flyspell in a buffer created by M-x report-emacs-bug, or
when flyspell is generally enabled for all text modes with (add-hook
'text-mode-hook 'flyspell-mode), an error from within post-command-
hook is thrown: `message-signature-separator' is void.
The reason for that is that `mail-mode-flyspell-verify' wrongly
assumes that `message-signature-separator' is defined. `report-emacs-
bug' enables mail mode, but does not load `message'.
A simple fix follows.
*** lisp/textmodes/flyspell.el 06 Apr 2008 12:51:35 +0100 1.118.2.6
--- lisp/textmodes/flyspell.el 12 Jun 2008 08:45:05 +0100
***************
*** 296,306 ****
"$")
nil t)
(point)))
! (signature-begin (save-excursion
! (goto-char (point-max))
! (re-search-backward message-signature-separator
! nil t)
! (point))))
(cond ((< (point) header-end)
(and (save-excursion (beginning-of-line)
(looking-at "^Subject:"))
--- 296,309 ----
"$")
nil t)
(point)))
! (signature-begin (if (not (boundp 'message-signature-separator))
! (point-max)
! (save-excursion
! (goto-char (point-max))
! (re-search-backward
! message-signature-separator
! nil t)
! (point)))))
(cond ((< (point) header-end)
(and (save-excursion (beginning-of-line)
(looking-at "^Subject:"))
next reply other threads:[~2008-06-12 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 7:48 David Reitter [this message]
2008-06-13 15:15 ` report-emacs-bug, flyspell Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24846EF2-8344-412F-8C46-41DA4E2AAC2A@gmail.com \
--to=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.