Some build issues

Some build issues

[Ergus]

Hi:

I have two issues during the build that probably may be checked.

I didn't report them as issues because they are not critical for most of
the users. 

1)

Just building master with a modern gcc (11.1) I am getting some
warnings. They are not critical, but I see that some recent commit are
eliminating gcc warnings, so probably you will like to fix these too.


../../src/comp.c: In function ‘declare_runtime_imported_funcs’:
../../src/comp.c:2696:5: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation]
  2696 |   } while (0)
       |     ^~~~~
../../src/comp.c:2704:3: note: in expansion of macro ‘ADD_IMPORTED’
  2704 |   ADD_IMPORTED (helper_PSEUDOVECTOR_TYPEP_XUNTAG, comp.bool_type, 2, args);
       |   ^~~~~~~~~~~~
../../src/comp.c:2690:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘while’
  2690 |   {                                                                            \
       |   ^

  (...)

../../src/image.c: In function ‘tiff_load’:
../../src/image.c:7980:3: warning: ‘uint32’ is deprecated [-Wdeprecated-declarations]
  7980 |   uint32 *buf;
       |   ^~~~~~
../../src/image.c:8106:7: warning: ‘uint32’ is deprecated [-Wdeprecated-declarations]
  8106 |       uint32 *row = buf + y * width;
       |       ^~~~~~
../../src/image.c:8110:11: warning: ‘uint32’ is deprecated [-Wdeprecated-declarations]
  8110 |           uint32 abgr = row[x];
       |           ^~~~~~
  
2)

Building in parallel (make -j install) it seems to install wrongly
because when I try to execute after that I get:

Error using execdir /home/user/.local/libexec/emacs/28.0.50/x86_64-pc-linux-gnu/../../../../bin/:
emacs:
/home/user/.local/libexec/emacs/28.0.50/x86_64-pc-linux-gnu/../../../../bin/../native-lisp/28.0.50-0f08941b/preloaded/window-ac748af0-63c191c3.eln:
cannot open shared object file: No such file or directory

If I run:

make
make install 

then everything works fine.

Best,
Ergus

Re: Some build issues

[Eli Zaretskii]

> Date: Fri, 18 Jun 2021 13:48:13 +0200
> From: Ergus <spacibba@aol.com>
> Cc: mattiase@acm.org, akrl@sdf.org
> 
> I have two issues during the build that probably may be checked.

Please report each issue as a separate bug.

The first one is just a nuisance, but the second one is a real
problem.

> I didn't report them as issues because they are not critical for most of
> the users. 

Please don't decide not to report issues based on such considerations.

Thanks.

Re: Some build issues

[Bob Rogers]

   From: Eli Zaretskii <eliz@gnu.org>
   Date: Fri, 18 Jun 2021 15:31:52 +0300

   > Date: Fri, 18 Jun 2021 13:48:13 +0200
   > From: Ergus <spacibba@aol.com>
   > Cc: mattiase@acm.org, akrl@sdf.org
   > 
   > I have two issues during the build that probably may be checked.
   >
   > I didn't report them as issues because they are not critical for
   > most of the users.

   Please don't decide not to report issues based on such considerations.

   Thanks.

If I may paraphrase Horton, "An issue is an issue, no matter how small."

					-- Bob Rogers
					   http://www.rgrjr.com/

Re: Some build issues

[Mattias Engdegård]

18 juni 2021 kl. 13.48 skrev Ergus <spacibba@aol.com>:

> ../../src/comp.c: In function ‘declare_runtime_imported_funcs’:
> ../../src/comp.c:2696:5: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation]
> 2696 |   } while (0)

Lovely, thank you! Really made me more cheerful today!

Andrea, I suggest we rename ADD_IMPORTED to ADD_IMPORTED_AND_IGNORE_NEXT_STATEMENT for clarity. What do you say?

Re: Some build issues

[Mattias Engdegård]

18 juni 2021 kl. 14.38 skrev Mattias Engdegård <mattiase@acm.org>:

> Andrea, I suggest we rename ADD_IMPORTED to ADD_IMPORTED_AND_IGNORE_NEXT_STATEMENT for clarity. What do you say?

Oh no, I overlooked the semicolon. Sorry, never mind that.