From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kai Ma Newsgroups: gmane.emacs.bugs Subject: bug#61521: "default" is now the first item returned from (font-faces), breaking various code. Date: Sat, 18 Feb 2023 14:54:12 +0800 Message-ID: <24615FB3-774C-4D53-A72B-4FFF53E22EAF@gmail.com> References: <7fe5e80d-761f-cc2d-12a1-65b2b5781c39@umanwizard.com> <9e9ed8043f57226204db@heytings.org> <3b75cf10-6125-608c-a506-323ce09846c7@umanwizard.com> <9e9ed8043fd479390a2a@heytings.org> <83ttznavsp.fsf@gnu.org> <9e9ed8043fd6413e6183@heytings.org> <83y1ovzcw6.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_5AAC2BF3-95CD-4629-9510-2DA594B03449" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3497"; mail-complaints-to="usenet@ciao.gmane.io" Cc: brennan@umanwizard.com, gregory@heytings.org, 61521@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 07:55:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTH7y-0000iL-7x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 07:55:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTH7g-000115-Lg; Sat, 18 Feb 2023 01:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTH7e-00010U-7e for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 01:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTH7d-0001L2-UC for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 01:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTH7d-0001Qn-N5 for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 01:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kai Ma Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 06:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61521 X-GNU-PR-Package: emacs Original-Received: via spool by 61521-submit@debbugs.gnu.org id=B61521.16767032765467 (code B ref 61521); Sat, 18 Feb 2023 06:55:01 +0000 Original-Received: (at 61521) by debbugs.gnu.org; 18 Feb 2023 06:54:36 +0000 Original-Received: from localhost ([127.0.0.1]:42246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTH7E-0001Q6-0j for submit@debbugs.gnu.org; Sat, 18 Feb 2023 01:54:36 -0500 Original-Received: from mail-pf1-f193.google.com ([209.85.210.193]:38531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTH7B-0001Pt-JQ for 61521@debbugs.gnu.org; Sat, 18 Feb 2023 01:54:34 -0500 Original-Received: by mail-pf1-f193.google.com with SMTP id j1so3667pfu.5 for <61521@debbugs.gnu.org>; Fri, 17 Feb 2023 22:54:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=K6VJWRhDicVGTdKimcEPea8P9ku1fF2jbDbX4tG+NUs=; b=dm3MUZTHE3WyryZ1/WkdcykgB2MikE/go+4WdFvohnZZ2rakt//K2V4FjHsariNl8r I1LgDkJlwGsI+rvfSRmIO8P7BtrvWGan9h3AbySN6lYY7K4lZDbZ+vooKpjtB4pWg2k+ hXThEB+QFmTkk/4B5brrAni9vJ6ds9kLo2d5ywHsQ9nZuwYJ0niMgdz6O0onG+WIz+4t Q65EHk5hot8O3rYJnXomU0C54BXAIHjK1fVzOgOxcGu84hIM5doIiJjVsTLwBekA+3eO KSKzWp4TpQQ0s5QjnWtEO+mt9iLRN9XtXA6wqH9tk+L1RBQBf1RQkfc4nALDRxfhm3H9 xM4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K6VJWRhDicVGTdKimcEPea8P9ku1fF2jbDbX4tG+NUs=; b=Z1H6lbq4vdMxRhAsHhxUzsIjRmyuarozVWakyyY+srp6udywDjZ+k9/qNyh3hHb2Ce NDf8RSXlPdSBCMzw2GhGbGebWFxTAYC0j9ofMMNeOeHo5wuYW1gAPNi554+YmA3mPxwf tRBeJyIUIKIBnDux/cyiz8zksYsl+eGE6nSVWjaLpDTimo4NI/zjZ90Fm19HLpOC0aSe tZ2juahmK7356Lp1RGq/bSav/ep4i8clDAoOT+au5woES4aRVl7TdbpZUNfioQp0P/Gk AVCvYAq0utmYIaP4+Z7qhnUtY5GgSgAskpizJ9iRNAna7Q5PbngZR3hZe42VG9EVMhpQ xQHA== X-Gm-Message-State: AO0yUKVL81GJCcLLyYgp1xJ6LJ4+jruzdApjxhE0eQtDVQTlys7j91CG oLT3S/JMkiSNcKJ1WNqTqjQ= X-Google-Smtp-Source: AK7set8qErsoGuq7l+JvEjvMrPQzAzW0wu+SemdKmFiyVtF9MTsBilk8WzfTlteXvSV+4ADEJ+jM1A== X-Received: by 2002:a62:31c7:0:b0:5a9:d734:7d2 with SMTP id x190-20020a6231c7000000b005a9d73407d2mr3907322pfx.32.1676703267355; Fri, 17 Feb 2023 22:54:27 -0800 (PST) Original-Received: from smtpclient.apple (36-238-6-26.dynamic-ip.hinet.net. [36.238.6.26]) by smtp.gmail.com with ESMTPSA id m9-20020aa78a09000000b005a8ae0c52cfsm2436349pfa.16.2023.02.17.22.54.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2023 22:54:26 -0800 (PST) In-Reply-To: <83y1ovzcw6.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255929 Archived-At: --Apple-Mail=_5AAC2BF3-95CD-4629-9510-2DA594B03449 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Feb 18, 2023, at 14:49, Eli Zaretskii wrote: >=20 >> From: Kai Ma > >> Cc: Eli Zaretskii >, = brennan@umanwizard.com , >> 61521@debbugs.gnu.org >> Date: Sat, 18 Feb 2023 06:17:25 +0800 >>=20 >> My config becomes broken after pulling this change: the child frame = of >> vertico-posframe does not appear under certain themes, and signals >> errors like: >>=20 >> Error in post-command-hook (vertico--exhibit): (error "Invalid face" = consult-separator) >> Error in post-command-hook (vertico--exhibit): (error "Invalid face" = hl-todo) >>=20 >> I'm not sure if this is a downstream issue, but this problem can be >> solved by either reverting this commit or removing the nreverse in >> x-create-frame-with-faces: >>=20 >> diff --git a/lisp/faces.el b/lisp/faces.el >> index 4933b495a6c..e91107e98cc 100644 >> --- a/lisp/faces.el >> +++ b/lisp/faces.el >> @@ -2226,7 +2226,7 @@ x-create-frame-with-faces >> (unwind-protect >> (progn >> (x-setup-function-keys frame) >> - (dolist (face (nreverse (face-list))) >> + (dolist (face (face-list))) >> (face-spec-recalc face frame)) >> (x-handle-reverse-video frame parameters) >> (frame-set-background-mode frame t) >>=20 >> This piece of code (w/ nreverse) was written as part of the hash = table >> rewrite, and at that time (face-list) did not sort its results. I = don't >> know why nreverse is significant here though. >=20 > Which change are you talking about? Please clarify. The fix of this bug, commit a555abc56d5 on branch emacs-29. > The original problem was solved recently on the emacs-29 branch by > reversing the order in which face-list sorts the faces, to make it > similar to what we had before the hash table rewrite. So there should > be no reason to change any other code anywhere else. >=20 > Thanks. --Apple-Mail=_5AAC2BF3-95CD-4629-9510-2DA594B03449 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Feb = 18, 2023, at 14:49, Eli Zaretskii <eliz@gnu.org> wrote:

From: Kai Ma = <justksqsf@gmail.com>
Cc: = Eli Zaretskii <eliz@gnu.org>, =  brennan@umanwizard.com,
&nbs= p;61521@debbugs.gnu.org
Date: = Sat, 18 Feb 2023 06:17:25 +0800

My config becomes broken after = pulling this change: the child frame of
vertico-posframe does not = appear under certain themes, and signals
errors = like:

 Error in post-command-hook (vertico--exhibit): (error = "Invalid face" consult-separator)
 Error in post-command-hook = (vertico--exhibit): (error "Invalid face" hl-todo)

I'm not sure = if this is a downstream issue, but this problem can be
solved by = either reverting this commit or removing the nreverse = in
x-create-frame-with-faces:

diff --git a/lisp/faces.el = b/lisp/faces.el
index 4933b495a6c..e91107e98cc 100644
--- = a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2226,7 +2226,7 @@ = x-create-frame-with-faces
    (unwind-protect
= (progn
  (x-setup-function-keys = frame)
- =   (dolist = (face (nreverse (face-list)))
+   (dolist (face = (face-list)))
    (face-spec-= recalc face frame))
  (x-handle-reverse-video= frame parameters)
  (frame-set-background-m= ode frame t)

This piece of code (w/ nreverse) was written as part = of the hash table
rewrite, and at that time (face-list) did not sort = its results.  I don't
know why nreverse is significant here = though.

Which = change are you talking about?  Please clarify.

The fix of this bug, = commit a555abc56d5 on branch = emacs-29.

The original problem was = solved recently on the emacs-29 branch by
reversing the order in which face-list sorts the faces, to = make it
similar to what we had = before the hash table rewrite.  So there should
be no reason to change = any other code anywhere else.

Thanks.

= --Apple-Mail=_5AAC2BF3-95CD-4629-9510-2DA594B03449--