From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix MH-E mail composition with GNU Mailutils Date: Sat, 30 Jun 2018 13:55:26 -0700 Message-ID: <24605.1530392126@alto> References: <83vaa0krmk.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Trace: blaine.gmane.org 1530392019 28195 195.159.176.226 (30 Jun 2018 20:53:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 30 Jun 2018 20:53:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 30 22:53:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZMsB-0007Fx-HS for ged-emacs-devel@m.gmane.org; Sat, 30 Jun 2018 22:53:35 +0200 Original-Received: from localhost ([::1]:47984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZMuI-00078G-IY for ged-emacs-devel@m.gmane.org; Sat, 30 Jun 2018 16:55:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZMu9-00073d-2Y for emacs-devel@gnu.org; Sat, 30 Jun 2018 16:55:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZMu5-0003TI-Vf for emacs-devel@gnu.org; Sat, 30 Jun 2018 16:55:37 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:36502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZMu5-0003SL-Mr; Sat, 30 Jun 2018 16:55:33 -0400 Original-Received: from alto (96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w5UKtQ9S029193 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 30 Jun 2018 13:55:32 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133] claimed to be alto In-Reply-To: Your message of "Sat, 30 Jun 2018 22:21:07 +0300." <83vaa0krmk.fsf@gnu.org> X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 26.1.50 Content-ID: <24604.1530392126.1@alto> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 198.144.192.42 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226857 Archived-At: Eli Zaretskii wrote: > > From: Mike Kupfer > > Date: Sat, 30 Jun 2018 12:00:40 -0700 > > > > Currently, trying to compose a message using MH-E with Mailutils fails: > > no composition buffer is created, and the user gets an obscure error > > message about deleting a non-empty directory. This has been broken for > > awhile (i.e., it's not a regression in 26.1), but the fix is pretty > > simple. Is this okay for emacs-26? > > Please at least explain the reason(s) for the problem. How else can > we reason about the necessity and risk(s) of getting this into > emacs-26. The problem comes about because of the way MH-E deals with some versions of nmh, which use a non-simple-text templating mechanism for mail composition, and which do not provide a convenient interface for MH-E mail composition. MH-E creates the draft email in a temporary folder and then removes the temporary folder, as part of setting up the composition buffer. Right now MH-E knows about the metadata file that nmh creates during the creation of the draft email, but Mailutils-MH has at least one other metadata file. So when MH-E tries to delete the temporary folder, the deletion errors out, which aborts the rest of the composition steps. > And shouldn't we invite the MH-E developers to this discussion? I posted this patch on June 7 on the MH-E developers list; see https://sourceforge.net/p/mh-e/mailman/mh-e-devel/?viewmonth=201806 for what little discussion there was. mike