From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: advice.el and bytecomp: Did something change recently? Date: Fri, 17 Apr 2020 12:45:48 -0700 Message-ID: <24218.1900.185221.487974@retriever.mtv.corp.google.com> References: <20200417165037.87CC5C22B24@raman-glaptop.localdomain> <24217.58861.727647.633990@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14903"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 17 21:48:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPWyG-0003mW-BY for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 21:48:16 +0200 Original-Received: from localhost ([::1]:51306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPWyF-0007tz-CU for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 15:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPWvz-0005Oa-Um for emacs-devel@gnu.org; Fri, 17 Apr 2020 15:45:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPWvy-0006YE-Vf for emacs-devel@gnu.org; Fri, 17 Apr 2020 15:45:55 -0400 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:36532) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPWvy-0006WN-N8 for emacs-devel@gnu.org; Fri, 17 Apr 2020 15:45:54 -0400 Original-Received: by mail-pg1-x52f.google.com with SMTP id o185so1056796pgo.3 for ; Fri, 17 Apr 2020 12:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=+3SSRqWX0F00mhRgdbNCHCAgAe54tCcckJkwAbRG/GU=; b=KqpHaBdPP8fjMOBi7Z6nLbfkbFltNrF/eXoqP8cLZblj8mmVXEItVowUGNXA1mraTm LPDAbY1Vtk9fWAD3pzcaFq+YST1XFnk/d4w20bSKUZdR3OWRd0YOSp55cEZ4hcP2MBye Okur2zSI8ehtgdEwTU2BKYBigQCj3td2s8VZ2DmMp4G6utgpNEu39MH7HcI4S+Wgl7co qB74/hYIw9gp/6RgBzoyvHqn74XifkCvBgX1A0eR1g1tv2kaAZAdYhgCbp8RuZH/WL22 IRCJSEGoW0Zee4TfAPCbgULxE95Cw2E35iWnkYV21akkUggzZuZt9DH6dBS7P7O8uUdw +CLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=+3SSRqWX0F00mhRgdbNCHCAgAe54tCcckJkwAbRG/GU=; b=VpACIkJkxar62Exh4pYhaMT3D+8zMVe+Jo1i0Nd74/4ChomBI3IIDgoiZ9jd8/fTPk ebI6XkODM/Mydojhy4rwc5ywba4Ya7NOK3d7c59CFiIH/ef275PGosunGz1U3EZtVVpd 0FJBXIWuMbmVWuCnk6oCwcDanywXveJuD0VBgGa7EfEAZqZhX3sHVl/7iATvaoBgq36T QyPg2OKN4yQJD/xB2kJi4Um+OV76ddSCct6vOY7Djr35KO3NTkNtHM1dXpwdzR/dp2vr ZCFSFK62AzNGSW9wgH42xHLDpIXi/S6e/ueYUlCuh1Zqb94zdw+wuDipBMem8Oz2ilwy J0IA== X-Gm-Message-State: AGi0PuY1D6oLyt79F4BGIrwLCjAg96NthzT2iiExN8lNADZhApEgiUo4 9/scXQJt74QXfs8KJNtda4oJxP5Damk= X-Google-Smtp-Source: APiQypJapYq0/LvQF8fn2leCBCKY6UGAWSWFmkRUIeYb1NnpqDUVtr/DLCK1qVTt6gge894OdHbfow== X-Received: by 2002:a63:7512:: with SMTP id q18mr4289219pgc.398.1587152750131; Fri, 17 Apr 2020 12:45:50 -0700 (PDT) Original-Received: from retriever.mtv.corp.google.com ([172.22.80.201]) by smtp.gmail.com with ESMTPSA id f64sm21402576pfb.72.2020.04.17.12.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 12:45:49 -0700 (PDT) Original-Received: by retriever.mtv.corp.google.com (Postfix, from userid 13930) id 3E4A118002E8; Fri, 17 Apr 2020 12:45:48 -0700 (PDT) In-Reply-To: X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247199 Archived-At: this is what I meant by "it's hard to debug with the complexity of Emacspeak". I've failed to produce a minimal repro case --- what I do observe: 1. Some advice defs are not taking effect i.e. I dont get the expected auditory feedback. 2. Evaluating the advice definition makes it work, even though the file containing the advice was already loaded when it was failing. Stefan Monnier writes: > > Is there any additional information that I can provide > > A reproduceable test case? > When I try > > M-: (defadvice sm-foo (before test activate) (message "before-advice")) RET > M-: (defun sm-foo () (message "body")) RET > M-: (sm-foo) RET > > the advice works just fine. > > > Stefan -- Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1