From: "T.V Raman" <raman@google.com>
To: monnier@iro.umontreal.ca
Cc: raman@google.com, emacs-devel@gnu.org
Subject: Re: advice.el and bytecomp: Did something change recently?
Date: Fri, 17 Apr 2020 12:45:48 -0700 [thread overview]
Message-ID: <24218.1900.185221.487974@retriever.mtv.corp.google.com> (raw)
In-Reply-To: <jwvd0859ahv.fsf-monnier+emacs@gnu.org>
this is what I meant by "it's hard to debug with the complexity of
Emacspeak".
I've failed to produce a minimal repro case --- what I do observe:
1. Some advice defs are not taking effect i.e. I dont get the
expected auditory feedback.
2. Evaluating the advice definition makes it work, even though the
file containing the advice was already loaded when it was failing.
Stefan Monnier writes:
> > Is there any additional information that I can provide
>
> A reproduceable test case?
> When I try
>
> M-: (defadvice sm-foo (before test activate) (message "before-advice")) RET
> M-: (defun sm-foo () (message "body")) RET
> M-: (sm-foo) RET
>
> the advice works just fine.
>
>
> Stefan
--
Id: kg:/m/0285kf1
--
Id: kg:/m/0285kf1
next prev parent reply other threads:[~2020-04-17 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 16:50 advice.el and bytecomp: Did something change recently? T.V Raman
2020-04-17 17:12 ` Stefan Monnier
2020-04-17 17:22 ` T.V Raman
2020-04-17 19:32 ` Stefan Monnier
2020-04-17 19:45 ` T.V Raman [this message]
2020-04-17 19:46 ` T.V Raman
2020-04-18 2:03 ` T.V Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24218.1900.185221.487974@retriever.mtv.corp.google.com \
--to=raman@google.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.