From: "T.V Raman" <raman@google.com>
To: raman@google.com
Cc: dgutov@yandex.ru, emacs-devel@gnu.org
Subject: Re: master@head: completing-read behavior change?
Date: Wed, 22 Jan 2020 16:03:33 -0800 [thread overview]
Message-ID: <24104.58069.333584.189273@retriever.mtv.corp.google.com> (raw)
In-Reply-To: <24104.57963.869782.597096@retriever.mtv.corp.google.com>
Fix is here for the curious:-)
https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85
T.V Raman writes:
> Found it -- ido--overlay (apologies)
>
> I was looking at the wrong branch earlier. Now have it working in both
> emacs 27 and emacs 28
> T.V Raman writes:
> > Yes, you nailed the problem. I need to update how I handle ido-exhibit
> > in my after advice. Thanks for the prompt help and pointer.
> > Dmitry Gutov writes:
> > > Hi T.V.,
> > >
> > > On 23.01.2020 0:42, T.V Raman wrote:
> > > > Could anyone tell me what changed in the behavior of completing-read
> > > > between
> > > > * (HEAD detached at 561ba2633e)
> > > > and HEAD on master branch?
> > >
> > > I can't find the revision 561ba2633e, but it could be commit
> > > 3b0938c0420de2b845e7e8f8fbbb57ddc61718f2.
> > >
> > > > From what I observe, something low-level appears to have changed how
> > > > completing-read produces its final minibuffer prompt when ido is active.
> > >
> > > The aforementioned commit changed the way Ido's suggestions are
> > > displayed: instead of being plainly 'insert'-ed, they are now an
> > > 'after-string' property on an overlay placed at the end of the prompt
> > > and input.
> > >
> > > > From emacspeak, I used to be able to speak the ido choices
> > > > intelligently, now I just get the number of available choices spoken
> > > > -- and the code on the emacspeak end hasn't changed.
> > >
> > > Does emacspeak work okay with icomplete-mode? The above is how the
> > > latter has been displaying its suggestions for some time.
> > >
> > > This change has been made for better compatibility with the new way
> > > messages are displayed while minibuffer is active (they are displayed
> > > using the same mechanism). So I think emacspeak should learn to
> > > understand this kind of rendering either way.
> > >
> > > Sorry for the inconvenience, though.
> >
> > --
> > Id: kg:/m/0285kf1
> >
> > --
> > Id: kg:/m/0285kf1
>
> --
> Id: kg:/m/0285kf1
>
> --
> Id: kg:/m/0285kf1
--
Id: kg:/m/0285kf1
--
Id: kg:/m/0285kf1
next prev parent reply other threads:[~2020-01-23 0:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 21:42 master@head: completing-read behavior change? T.V Raman
2020-01-22 21:56 ` Dmitry Gutov
2020-01-22 23:53 ` T.V Raman
2020-01-23 0:01 ` T.V Raman
2020-01-23 0:03 ` T.V Raman [this message]
2020-01-23 13:58 ` Dmitry Gutov
2020-01-23 14:44 ` T.V Raman
2020-01-23 14:49 ` Dmitry Gutov
2020-01-23 16:45 ` T.V Raman
2020-01-23 17:19 ` Dmitry Gutov
2020-01-22 23:55 ` T.V Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24104.58069.333584.189273@retriever.mtv.corp.google.com \
--to=raman@google.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.