From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Charalampos Mitrodimas Newsgroups: gmane.emacs.bugs Subject: bug#17219: 24.3.50; wrong alignment when a list is given to dired Date: Mon, 23 Dec 2024 00:25:26 +0000 Message-ID: <240007c8-70a4-432f-a28d-bcf9662ad757@posteo.net> References: <877g71yrdc.fsf@yahoo.fr> <87a5cn77dx.fsf@kubajecminek.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5204"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Nicolas Richard , 17219@debbugs.gnu.org To: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 23 01:26:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPWHA-0001EH-3s for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Dec 2024 01:26:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPWGq-000735-S0; Sun, 22 Dec 2024 19:26:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPWGp-00072j-0l for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 19:26:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPWGo-0002lK-OI for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 19:26:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=lCMMusvfylhYC/ktVW0OnaBJxjk/S1sgw8hGg1mvdlI=; b=MKEI/iuR7Sztq16aeG48XGH8pghgLZqePNGV9XMbWTPqg8/xY03f3/773rE0z8qKq2oZ8X0M2X2k95D/EBhgV3ipfZSA78qLQUyds8oVqnM48ZFaov2GYmI2V9b7NVf0BSiB3xrRR0ponRR1HlvRx7OngcuQcB/A3VfTnDNVs4ue/ScKKu4JSupDPpUQk+dDfzjzktL23ZRSNSVMZCeBHOwBGTqTd84YUxVL8LVci3bulPdRyn+gvZlMEnHZokbDOlvAqUKOEYzF086yio3ecDYxYOKWKn70ajOBXasf7RKKT8VKcr3g7hFzpej30NZoil835iSWGjKE0U+NXI0vDA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPWGo-0002DM-Dv for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 19:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Charalampos Mitrodimas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Dec 2024 00:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 17219-submit@debbugs.gnu.org id=B17219.17349135388475 (code B ref 17219); Mon, 23 Dec 2024 00:26:02 +0000 Original-Received: (at 17219) by debbugs.gnu.org; 23 Dec 2024 00:25:38 +0000 Original-Received: from localhost ([127.0.0.1]:52502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPWGP-0002Cd-Ui for submit@debbugs.gnu.org; Sun, 22 Dec 2024 19:25:38 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:51751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPWGM-0002CL-VK for 17219@debbugs.gnu.org; Sun, 22 Dec 2024 19:25:36 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E7BC6240101 for <17219@debbugs.gnu.org>; Mon, 23 Dec 2024 01:25:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734913528; bh=/CsO1VQOvsAw5dsy0cQXTdjetDF7ce59Gkj0jco9ALQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=edQsEqhep37n67XAQ/VmeFj+8RdWJfJJu6uvi2x013wI2xp0dd+Sq3Mg4X4mctHG3 R70ZnOEtwTgZvDKONI65U02Y94p94AFLgUe3NaVtU4PIHZl1SCZIMzf+ceAdmMVmLV Gm3LIoNQODL7BoWct7KA3Fk0FuACRvhexWjcL6+vqoDYaCYRj2IwQLBj2ugxGC48+B szwTG8LMjVt3ZVW8ciPgnk/453xJc8kvLIGdRbwvxVpZuyjWEwEVlbit4xxo6XKOmV f14H55qEPpYhDlyyeyKUNnz5+1JzRw0wgu0bTV8KOUZqfJqvg10cjegHeRH7cB9058 zqIAMEPsW+kLQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YGf1g52YPz9rxD; Mon, 23 Dec 2024 01:25:27 +0100 (CET) Content-Language: en-US In-Reply-To: <87a5cn77dx.fsf@kubajecminek.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297634 Archived-At: Hi Jakub, On 22/12/24 11:08 PM, Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > It seems that adding simple `dired--align-all-files' to the end of > `dired-revert' resolves this. > > From 41780fde84fe1c55a0a7417a833dc0b8303a3db8 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jakub=20Je=C4=8Dm=C3=ADnek?= > Date: Sun, 22 Dec 2024 21:53:53 +0100 > Subject: [PATCH] Align files after dired revert (Bug#17219) > > * lisp/dired.el (dired-revert): Add dired--align-all-files > function call. > --- > lisp/dired.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/dired.el b/lisp/dired.el > index 028b862d159..acd31fb6424 100644 > --- a/lisp/dired.el > +++ b/lisp/dired.el > @@ -2157,7 +2157,8 @@ dired-revert > (if (dired-goto-subdir dir) > (dired-hide-subdir 1)))) > (unless modflag (restore-buffer-modified-p nil)) > - (hack-dir-local-variables-non-file-buffer)) > + (hack-dir-local-variables-non-file-buffer) > + (dired--align-all-files)) What about performance? Depending on the size of the directory, recalculating alignment could have a minor performance impact. > ;; outside of the let scope > ;;; Might as well not override the user if the user changed this. > ;;; (setq buffer-read-only t) -- C. Mitrodimas