all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Charalampos Mitrodimas <charmitro@posteo.net>
To: "Jakub Ječmínek" <kuba@kubajecminek.cz>, "Eli Zaretskii" <eliz@gnu.org>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>, 17219@debbugs.gnu.org
Subject: bug#17219: 24.3.50; wrong alignment when a list is given to dired
Date: Mon, 23 Dec 2024 00:25:26 +0000	[thread overview]
Message-ID: <240007c8-70a4-432f-a28d-bcf9662ad757@posteo.net> (raw)
In-Reply-To: <87a5cn77dx.fsf@kubajecminek.cz>

Hi Jakub,


On 22/12/24 11:08 PM, Jakub Ječmínek via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> It seems that adding simple `dired--align-all-files' to the end of
> `dired-revert' resolves this.
>
>  From 41780fde84fe1c55a0a7417a833dc0b8303a3db8 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jakub=20Je=C4=8Dm=C3=ADnek?= <kuba@kubajecminek.cz>
> Date: Sun, 22 Dec 2024 21:53:53 +0100
> Subject: [PATCH] Align files after dired revert (Bug#17219)
>
> * lisp/dired.el (dired-revert): Add dired--align-all-files
> function call.
> ---
>   lisp/dired.el | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index 028b862d159..acd31fb6424 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -2157,7 +2157,8 @@ dired-revert
>   	(if (dired-goto-subdir dir)
>   	    (dired-hide-subdir 1))))
>       (unless modflag (restore-buffer-modified-p nil))
> -    (hack-dir-local-variables-non-file-buffer))
> +    (hack-dir-local-variables-non-file-buffer)
> +    (dired--align-all-files))
What about performance? Depending on the size of the directory, 
recalculating alignment could have a minor performance impact.
>     ;; outside of the let scope
>   ;;;  Might as well not override the user if the user changed this.
>   ;;;  (setq buffer-read-only t)


--
C. Mitrodimas






  reply	other threads:[~2024-12-23  0:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 17:35 bug#17219: 24.3.50; wrong alignment when a list is given to dired Nicolas Richard
2019-08-15  0:03 ` Lars Ingebrigtsen
2019-09-19 16:18   ` Nicolas Richard via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-09-20  6:28     ` Eli Zaretskii
2019-09-20 12:48     ` Lars Ingebrigtsen
2024-12-22 21:08 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-23  0:25   ` Charalampos Mitrodimas [this message]
2024-12-23 17:52     ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-23 18:20       ` Charalampos Mitrodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=240007c8-70a4-432f-a28d-bcf9662ad757@posteo.net \
    --to=charmitro@posteo.net \
    --cc=17219@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kuba@kubajecminek.cz \
    --cc=theonewiththeevillook@yahoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.