From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Please add comments to isearch.el Date: Sun, 29 Nov 2015 08:54:39 -0800 (PST) Message-ID: <23d71522-5e32-4fff-b8ae-369716c2dbb2@default> References: <<83fuzoojcn.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448816114 13594 80.91.229.3 (29 Nov 2015 16:55:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Nov 2015 16:55:14 +0000 (UTC) To: Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 29 17:54:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a35FZ-0008Ek-9j for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 17:54:57 +0100 Original-Received: from localhost ([::1]:36952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a35Fd-0007TV-67 for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 11:55:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a35FQ-0007TM-Hg for emacs-devel@gnu.org; Sun, 29 Nov 2015 11:54:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a35FP-0002EM-OF for emacs-devel@gnu.org; Sun, 29 Nov 2015 11:54:48 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:19201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a35FL-0002AE-PD; Sun, 29 Nov 2015 11:54:43 -0500 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tATGsfGg005529 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 29 Nov 2015 16:54:41 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id tATGsf2O006909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 29 Nov 2015 16:54:41 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tATGsexP025762; Sun, 29 Nov 2015 16:54:40 GMT In-Reply-To: <<83fuzoojcn.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195552 Archived-At: > Would someone "in the know" please add commentary to isearch.el to > explain how the various options are passed to the commands defined > there and affect or not affect them? >=20 > The isearch.el commands are implemented using complex multi-layered > system of functions and macros that make it very hard to figure out, > just by looking at the code, which options affect what commands and in > what ways. About the only way to find that out is by trying each > command, which is very inefficient. I think it will help make this > file much more maintainable if commentary were added there explaining > how all of this works. Thanks in advance. +1 Particularly as regards the state structure and updating it.