From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs Date: Wed, 24 Feb 2016 02:25:43 +0200 Message-ID: <23ac5130-b782-a055-3e38-a14810a9e007@yandex.ru> References: <87ppgtt95n.fsf@secretsauce.net> <8760xfobhx.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1456273583 14921 80.91.229.3 (24 Feb 2016 00:26:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Feb 2016 00:26:23 +0000 (UTC) Cc: 18110@debbugs.gnu.org To: Lars Ingebrigtsen , Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 24 01:26:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYNHO-0004nZ-3O for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Feb 2016 01:26:10 +0100 Original-Received: from localhost ([::1]:60704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYNHN-0000pM-KQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 19:26:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYNHJ-0000p2-Et for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 19:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYNHG-0006qs-8B for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 19:26:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYNHG-0006qo-4N for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 19:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aYNHG-0000DW-0Y for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 19:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 00:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18110 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18110-submit@debbugs.gnu.org id=B18110.1456273552820 (code B ref 18110); Wed, 24 Feb 2016 00:26:01 +0000 Original-Received: (at 18110) by debbugs.gnu.org; 24 Feb 2016 00:25:52 +0000 Original-Received: from localhost ([127.0.0.1]:41812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYNH6-0000D8-6S for submit@debbugs.gnu.org; Tue, 23 Feb 2016 19:25:52 -0500 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:35465) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYNH4-0000Cs-G3 for 18110@debbugs.gnu.org; Tue, 23 Feb 2016 19:25:50 -0500 Original-Received: by mail-wm0-f49.google.com with SMTP id c200so246106312wme.0 for <18110@debbugs.gnu.org>; Tue, 23 Feb 2016 16:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=fbSlc2kGO02l+nmXm3KPv8L6e8Xq3PccIHpbVYAiSno=; b=hvwdHoz2SpToFxEYsHFfNIlPRDnYBGVayWSVCC9O7yZmZaA5OTqCJPMbP9aqySU2AC AxNmwilDEdRWB0JspJ+cZ+vc5Kc50FO1YHlt/OWOtdz53KItoqBr6FLKHyGC4u1bAZIB 2URqBs7hKagxAWh9mHm1oM8UzUgKNirjOIX8lzOdbZvo8f+l7Xi3CtfFhGBND3q3akv5 1G0GSROrWxXB8EKeZwjzL5IEBDBUqNargtNVmAHlC+xACxW1EfyuvZvt4WiZTBZ9nqxM 2Ivat5lmPvUon63WY+dgL8qutwBilGDc+sw5vdpLYy29VqghiKzCA4Rsglujex61fiqj BVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=fbSlc2kGO02l+nmXm3KPv8L6e8Xq3PccIHpbVYAiSno=; b=biD8oMEmuKfJVtsaguF26nIXkNz7xaRMkFBbsVydiPjAdic68WKK54zRzb/+V0Wu1D 5NvP29WnliaT7FnAva9UESppXXOqsSMsX4PI/mW5+4YZ+l9rBHFuzA5o3JxMBsi8k4bU 6NYqGJ2KJTXS0Tsku1a1dxfdf+D3M819EA9kZoLw7MGKutfDuDvtSpwYnZJvUW5JPr+n 5F219oxav3Lq2Xko+CG9O1r0PyIuIGlOCrnVCmJ1wjpmKbxyIPrLbzI0h6z/Bwi8g+rW UlpGDBcvfpcXyRg3k7H9ArSf9Wbqhml6F1/6Vsh+tdBSeG2aJnB+Y3zed/jd7wRKehqs 3Log== X-Gm-Message-State: AG10YOTVhiaS2xSalMBpdl0JUNt8TN6WtwF4t8ZavjI9Dw63T+WoBCce6cxWKTtU6ZguhQ== X-Received: by 10.194.89.70 with SMTP id bm6mr42756094wjb.0.1456273545006; Tue, 23 Feb 2016 16:25:45 -0800 (PST) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id w136sm28295522wmw.0.2016.02.23.16.25.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Feb 2016 16:25:44 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <8760xfobhx.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113620 Archived-At: On 02/23/2016 02:30 PM, Lars Ingebrigtsen wrote: >> - (unless (eobp) >> - ;; Indent the expanded log entry. >> - (indent-region (point-min) (point-max) 2) >> - (buffer-string)))) >> + (unless (eobp) (buffer-string)))) > > It seems like a deliberate design choice... I have no idea whether it's > a good one, though. Anybody? Not wasting extra horizontal space seems like a good choice. It might be implemented in a smarter way, though, like chopping off first two characters from each non-empty line, instead of reindenting them all. I'd be happy to see a patch along these lines.