From: Carsten Dominik <carsten.dominik@gmail.com>
To: Adam Spiers <orgmode@adamspiers.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: org-show-effort ideas
Date: Wed, 4 Nov 2009 14:19:47 +0100 [thread overview]
Message-ID: <2397914D-ECB8-4CC7-A157-FC4C3149FD7D@gmail.com> (raw)
In-Reply-To: <20091104002608.GH32187@atlantic.linksys.moosehall>
Hi Adam,
On Nov 4, 2009, at 1:26 AM, Adam Spiers wrote:
> Benjamin Andresen (benny@in-ulm.de) wrote:
>> Adam Spiers <orgmode@adamspiers.org> writes:
>>
>>> I definitely did try it, and I just did another 'git pull' and tried
>>> again, and I still don't see it, so I guess we're talking about
>>> different things ;-)
>>>
>>> To clarify, I'm referring to showing effort via a single keystroke
>>> when on a todo line in the *Org Agenda* buffer. Currently, when I
>>> hit
>>> "e" on a todo which has an existing "Effort" property value set, my
>>> minibuffer prompt shows "Value: ". The same applies with C-c C-x
>>> e in
>>> a normal .org file buffer.
>>
>> When I press 'e' in an agenda on an item that has the Effort property
>> value set, I get a minibuffer prompt that shows "Value [5]: " when
>> the
>> Effort value is 5.
>>
>> This is with a git version from Sunday morning.
>>
>> Check the source of the function org-set-effort, it will show you
>> that
>> it concats "[" cur "]", where cur is the current Effort prop value.
>
> Thanks for the pointer - it seems that the "[" cur "]" is only
> included when
>
> (org-property-get-allowed-values nil prop 'table)
>
> is nil - and in my case I have a global Effort_ALL property set which
> means that this is never the case. So I think this is a bug which can
> be trivially fixed by assigning the prompt string in the let* variable
> list, and then using it in both invocations of org-completing-read.
You are right, and it is fixed now.
- Carsten
prev parent reply other threads:[~2009-11-04 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 13:49 org-show-effort ideas Adam Spiers
2009-11-03 6:47 ` Carsten Dominik
2009-11-03 12:11 ` Adam Spiers
2009-11-03 14:42 ` Benjamin Andresen
2009-11-04 0:26 ` Adam Spiers
2009-11-04 13:19 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2397914D-ECB8-4CC7-A157-FC4C3149FD7D@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=orgmode@adamspiers.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.