Bug: org-agenda-undo does not work on repeated tasks [7.9.3d (7.9.3d-dist @ /home/wlin/.emacs-lisp/org/lisp/)]

Bug: org-agenda-undo does not work on repeated tasks [7.9.3d (7.9.3d-dist @ /home/wlin/.emacs-lisp/org/lisp/)]

[Wanrong Lin]

Emacs  : GNU Emacs 23.3.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.5)
  of 2011-08-14 on allspice, modified by Debian
Package: Org-mode version 7.9.3d (7.9.3d-dist @ 
/home/myth/.emacs-lisp/org/lisp/)

To reproduce:

In an org agenda buffer, mark a task as done. Then, run org-agenda-undo. 
If the task is a repeated task like this:

* TODO A weekly repeated task
   SCHEDULED: <2013-03-03 Sun +1w>

After mark a task as done from the agenda buffer, it becomes:

* TODO A weekly repeated task
   SCHEDULED: <2013-03-10 Sun +1w>
   :LOGBOOK:
   - State "DONE"       from "TODO"       [2013-03-03 Sun 12:43]
   :END:
   :PROPERTIES:
   :LAST_REPEAT: [2013-03-03 Sun 12:43]
   :END:

Then, if I run org-agenda-undo (with C-z) in agenda buffer,

* TODO A weekly repeated task
   SCHEDULED: <2013-03-10 Sun +1w>
   :LOGBOOK:
   :END:
   :PROPERTIES:
   :LAST_REPEAT: [2013-03-03 Sun 12:43]
   :END:

As you can see, the LOGBOOK changed, but the SCHEDULED time did not go 
back to the original.

Thanks for looking into it.

Re: Bug: org-agenda-undo does not work on repeated tasks [7.9.3d (7.9.3d-dist @ /home/wlin/.emacs-lisp/org/lisp/)]

[Bastien]

Hi Wanrong,

Wanrong Lin <wrglin@gmail.com> writes:

> Emacs  : GNU Emacs 23.3.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.5)
>  of 2011-08-14 on allspice, modified by Debian
> Package: Org-mode version 7.9.3d (7.9.3d-dist @
> /home/myth/.emacs-lisp/org/lisp/)
>
> To reproduce:
>
> In an org agenda buffer, mark a task as done. Then, run org-agenda-undo. If
> the task is a repeated task like this:
>
> * TODO A weekly repeated task
>   SCHEDULED: <2013-03-03 Sun +1w>
>
> After mark a task as done from the agenda buffer, it becomes:
>
> * TODO A weekly repeated task
>   SCHEDULED: <2013-03-10 Sun +1w>
>   :LOGBOOK:
>   - State "DONE"       from "TODO"       [2013-03-03 Sun 12:43]
>   :END:
>   :PROPERTIES:
>   :LAST_REPEAT: [2013-03-03 Sun 12:43]
>   :END:
>
> Then, if I run org-agenda-undo (with C-z) in agenda buffer,
>
> * TODO A weekly repeated task
>   SCHEDULED: <2013-03-10 Sun +1w>
>   :LOGBOOK:
>   :END:
>   :PROPERTIES:
>   :LAST_REPEAT: [2013-03-03 Sun 12:43]
>   :END:
>
> As you can see, the LOGBOOK changed, but the SCHEDULED time did not go back
> to the original.
>
> Thanks for looking into it.

Thanks a lot for reporting this obscure bug.  It is now fixed.

-- 
 Bastien

Bug: Entries with diary-sexps in "scheduled" not exported properly to calendar file (.ics file)

[Wanrong Lin]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

Org-mode version 9.2.2, Emacs 26.1, Windows 10

To reproduce:

Create a file "Test.org", with only one entry:

----------------------------------------------------------------------------

* TODO Do this on the second Monday every month
   SCHEDULED: <%%(diary-float t 1 2) 19:00-20:30>
   :PROPERTIES:
   :ID:       5eb2262f-d7a4-4c10-8765-e1906a1cf276
   :END:

------------------------------------------------------------------------------

Run this in the buffer of this above file:

M-x org-icalendar-export-to-ics

Check the output file "Test.ics", and you will see something like below, 
which obviously is wrong (I highlighted the wrong part).

BTW: regular org-agenda still works correctly with this entry (the TODO 
shows up correct at the right date)

-------------------------------------------------------------------------------

BEGIN:VCALENDAR
VERSION:2.0
X-WR-CALNAME:Test
PRODID:-////Emacs with Org mode//EN
X-WR-TIMEZONE:America/New_York
X-WR-CALDESC:
CALSCALE:GREGORIAN
BEGIN:VTODO

UID:TODO-5eb2262f-d7a4-4c10-8765-e1906a1cf276

DTSTAMP:20190326T141906Z

*DTSTART:20190326T101900*

SUMMARY:Do this on the second Monday every month

CATEGORIES:Test

SEQUENCE:1

PRIORITY:13

STATUS:NEEDS-ACTION

END:VTODO
END:VCALENDAR

-------------------------------------------------------------------------------


[-- Attachment #2: Type: text/html, Size: 2021 bytes --]

Re: Bug: Entries with diary-sexps in "scheduled" not exported properly to calendar file (.ics file)

[Thomas Plass]

Hi,

Wanrong Lin wrote at 10:23 on March 26, 2019:
: 
: * TODO Do this on the second Monday every month
:   SCHEDULED: <%%(diary-float t 1 2) 19:00-20:30>
: 
: M-x org-icalendar-export-to-ics

Org agenda has its own processing of sexps, so its views are correct.
The exporter, however, uses icalendar.el for creating the iCal data.
Date processing there in `icalendar--convert-float-to-ical' is
somewhat arbitrary as per the docstring:

  "Convert float diary entry to iCalendar format -- partially unsupported!

  FIXME! DAY from diary-float yet unimplemented.

As far as the exported date is concerned, it'll always be today's
date as per this comment further down:

  ;;Start today (yes this is an arbitrary choice):

So, bug-gnu-emacs would be the list to post this issue to.

Regards

Thomas

Re: Bug: Entries with diary-sexps in "scheduled" not exported properly to calendar file (.ics file)

[Wanrong Lin]

Thanks for the explanation. My limited debugging showed the data may not 
even be passed from org to icalendar.el ("scheduled: nil" in the entry). 
But from what you said it won't work anyway regardless.

This is a bit of bummer. As a work around, do you know if there is a way 
to generate a series of dates / org entries from a diary-sexps? Thanks.

Wanrong

On 3/26/2019 2:21 PM, Thomas Plass wrote:
> Hi,
>
> Wanrong Lin wrote at 10:23 on March 26, 2019:
> :
> : * TODO Do this on the second Monday every month
> :   SCHEDULED: <%%(diary-float t 1 2) 19:00-20:30>
> :
> : M-x org-icalendar-export-to-ics
>
> Org agenda has its own processing of sexps, so its views are correct.
> The exporter, however, uses icalendar.el for creating the iCal data.
> Date processing there in `icalendar--convert-float-to-ical' is
> somewhat arbitrary as per the docstring:
>
>    "Convert float diary entry to iCalendar format -- partially unsupported!
>
>    FIXME! DAY from diary-float yet unimplemented.
>
> As far as the exported date is concerned, it'll always be today's
> date as per this comment further down:
>
>    ;;Start today (yes this is an arbitrary choice):
>
> So, bug-gnu-emacs would be the list to post this issue to.
>
> Regards
>
> Thomas
>
>
>

Re: Bug: Entries with diary-sexps in "scheduled" not exported properly to calendar file (.ics file)

[Thomas Plass]

Wanrong Lin wrote at 15:20 on March 26, 2019:
: 
: As a work around, do you know if there is a way 
: to generate a series of dates / org entries from a diary-sexps? Thanks.

Evaluating those sexp is done in diary-lib.  But it's no use simply
supplying arguments to functions there as they require external setup,
in particular variables such the current DATE (mon day year), itself
coming from calendar.el.  However, it's exactly such dates that you
are looking for in the first place.  I guess, in your example
(diary-float t 1 2) you might have to loop through all the days of all
months (calendar knows about those) to see whether your sexp evaluates
to something useful.  But I haven't looked at that in detail.

Thomas

Re: Bug: Entries with diary-sexps in "scheduled" not exported properly to calendar file (.ics file)

[Wanrong Lin]

I just wrote a function to do it, and hope it can help other people with 
similar needs:

;; example: (dates-from-diary-sexp "2019-04-01" "2019-09-01" 
"(diary-float t 1 2)")
;; => ((8 12 2019) (7 8 2019) (6 10 2019) (5 13 2019) (4 8 2019))
(defun dates-from-diary-sexp (start end diary-sexp)
   "Given a start and ending date, returns all valid dates between them 
that satisfy diary-sexp"
   (let ((day-absolute (org-time-string-to-absolute start))
         (end-absolute (org-time-string-to-absolute end))
         (sexp (car (read-from-string diary-sexp)))
         (dates))
     (while (< day-absolute end-absolute)
       (let ((date (calendar-gregorian-from-absolute day-absolute))
             (entry nil))
         (when (eval sexp)
           (setf dates (cons date dates)))
         (incf day-absolute)))
     dates))

On 3/26/2019 5:01 PM, Thomas Plass wrote:
> Wanrong Lin wrote at 15:20 on March 26, 2019:
> :
> : As a work around, do you know if there is a way
> : to generate a series of dates / org entries from a diary-sexps? Thanks.
>
> Evaluating those sexp is done in diary-lib.  But it's no use simply
> supplying arguments to functions there as they require external setup,
> in particular variables such the current DATE (mon day year), itself
> coming from calendar.el.  However, it's exactly such dates that you
> are looking for in the first place.  I guess, in your example
> (diary-float t 1 2) you might have to loop through all the days of all
> months (calendar knows about those) to see whether your sexp evaluates
> to something useful.  But I haven't looked at that in detail.
>
> Thomas