all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Adrian Robert <arobert@cogsci.ucsd.edu>
Subject: Re: EVENT_INIT and obs. kbd_buffer_gcpro: 'arg' init still needed?
Date: Thu, 01 Jun 2006 09:16:47 -0400	[thread overview]
Message-ID: <234E2E03-FF18-41F6-82B8-B476AB47C201@cogsci.ucsd.edu> (raw)
In-Reply-To: <wlpshtdwrk.wl%mituharu@math.s.chiba-u.ac.jp>


On Jun 1, 2006, at 5:56 AM, YAMAMOTO Mitsuharu wrote:

>>>>>> On Wed, 31 May 2006 09:50:35 -0400, Adrian Robert  
>>>>>> <arobert@cogsci.ucsd.edu> said:
>
>> One use of the termhooks.h EVENT_INIT() macro in macterm.c also takes
>> care to init the event's 'arg' to "Qnil", explaining with this  
>> comment:
>
>>        /* It is necessary to set this (additional) argument slot  
>> of an
>> 	 event to nil because keyboard.c protects incompletely
>> 	 processed event from being garbage collected by placing them
>> 	 in the kbd_buffer_gcpro vector.  */
>
>> However, according to the ChangeLog this vector was removed on
>> 2004-01-21 in response to changes on 2003-06-15, including the very
>> introduction of the EVENT_INIT() macro.
>
> I removed this comment that is referring to a nonexistent variable
> from macterm.c.
>
>> My question is, is the additional call to set 'arg' to "Qnil", found
>> in w32, mac, and x terms, still needed?  I notice that macterm does
>> not have it for other calls to EVENT_INIT.  Other terms only use
>> EVENT_INIT once.
>
> Although bzero'ed Lisp_Object corresponds to integer 0 and thus it
> does not leads to a real problem, I think we should not rely on this.
> So I added some code to set `arg' to Qnil in macterm.c.

So a non-nil 'arg' CAN lead to errors?
Then is there any reason not to do the Qnil init in the EVENT_INIT  
macro?  All places using it have lisp.h.

      reply	other threads:[~2006-06-01 13:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31 13:50 EVENT_INIT and obs. kbd_buffer_gcpro: 'arg' init still needed? Adrian Robert
2006-06-01  9:56 ` YAMAMOTO Mitsuharu
2006-06-01 13:16   ` Adrian Robert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=234E2E03-FF18-41F6-82B8-B476AB47C201@cogsci.ucsd.edu \
    --to=arobert@cogsci.ucsd.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.