make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

[john muhl]

a fresh checkout or `git clean -dx` might be needed for reproduction.
fails on latest stable Debian and Fedora.

15693c8: https://builds.sr.ht/~johnmuhl/job/654631#bottom
f6967d2: https://builds.sr.ht/~johnmuhl/job/654649#bottom

Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

[Robert Pluim]

>>>>> On Wed, 22 Dec 2021 04:33:16 -0600, john muhl <email@johnmuhl.mx> said:

    john> a fresh checkout or `git clean -dx` might be needed for reproduction.
    john> fails on latest stable Debian and Fedora.

    john> 15693c8: https://builds.sr.ht/~johnmuhl/job/654631#bottom
    john> f6967d2: https://builds.sr.ht/~johnmuhl/job/654649#bottom

This is due to adding a binding in the minibuffer map, and not
updating help-tests-substitute-command-keys/keymaps

    commit 15693c81163e70b5df786e7c034bd236a40794bb
    Author: Philip Kaludercic <philipk@posteo.net>
    Date:   Thu Dec 9 17:26:14 2021 +0100

(does sr.ht run a build on every commit?)

Robert
-- 

Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

[Stefan Kangas]

Robert Pluim <rpluim@gmail.com> writes:

> This is due to adding a binding in the minibuffer map, and not
> updating help-tests-substitute-command-keys/keymaps

We should probably make these tests less brittle.

Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

[Lars Ingebrigtsen]

Stefan Kangas <stefankangas@gmail.com> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>> This is due to adding a binding in the minibuffer map, and not
>> updating help-tests-substitute-command-keys/keymaps
>
> We should probably make these tests less brittle.

Yup.  Testing for the entire keymap (of keymaps that change, like the
minibuffer map) is too much work.  It'd be better if the tests just
defined their own maps.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Yup.  Testing for the entire keymap (of keymaps that change, like the
> minibuffer map) is too much work.  It'd be better if the tests just
> defined their own maps.

Now fixed on master (commit 205030ba5a).

Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb

[john muhl]

On Wed, 2021-12-22 at 12:09 +0100, Robert Pluim wrote:
>     commit 15693c81163e70b5df786e7c034bd236a40794bb
>     Author: Philip Kaludercic <philipk@posteo.net>
>     Date:   Thu Dec 9 17:26:14 2021 +0100
> 
> (does sr.ht run a build on every commit?)

no these are ad-hoc builds. of course it can run on each commit. i'm
working on setting that up but it might be a few days so if anyone
else wanted to have a go at it that would be fine.