all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Set also the group of installed files
Date: Thu, 21 Jun 2018 17:27:28 +0200	[thread overview]
Message-ID: <23339.50144.819516.554832@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <83sh5gqjh6.fsf@gnu.org>

>>>>> On Thu, 21 Jun 2018, Eli Zaretskii wrote:

>> --- a/Makefile.in
>> +++ b/Makefile.in
>> @@ -518,7 +518,10 @@ INSTALL_ARCH_INDEP_EXTRA = @INSTALL_ARCH_INDEP_EXTRA@
>> set_installuser=for installuser in $${LOGNAME} $${USERNAME} $${USER} \
>> `id -un 2> /dev/null`; do \
>> [ -n "$${installuser}" ] && break ; \
>> -	done
>> +	done; \
>> +	installgroup=$$(id -gn 2>/dev/null); \
>> +	[ -n "$${installgroup}" ] && \
>> +	  installuser="$${installuser}:$${installgroup}"

> Is 'id' sufficiently portable to use it here?

The -g and -n options are specified by POSIX. I have only tested it on
GNU/Linux and FreeBSD though.

Also it should fall back to the current behaviour if "id" errors
out for some reason.



  reply	other threads:[~2018-06-21 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 14:31 [PATCH] Set also the group of installed files Ulrich Mueller
2018-06-21 14:53 ` Eli Zaretskii
2018-06-21 15:27   ` Ulrich Mueller [this message]
2018-06-21 20:32     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23339.50144.819516.554832@a1i15.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.