From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: :extend t inheritance Date: Sat, 26 Oct 2019 13:41:33 +0200 Message-ID: <232434FE-611D-4357-AA7A-95E99CB66E2F@aol.com> References: <87zhhrmcaq.fsf@kenko.localhost.com> <83o8y6xnmn.fsf@gnu.org> <20191026014911.7riwc5oq6epjhdiq@Ergus> <87pnijkhrm.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="35957"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android Cc: emacs-devel@gnu.org To: Ingo Lohmar ,Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 26 13:47:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOKXq-00099i-PE for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 13:47:46 +0200 Original-Received: from localhost ([::1]:39808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOKXp-00040U-1h for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 07:47:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35813) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOKXA-0003vs-Q0 for emacs-devel@gnu.org; Sat, 26 Oct 2019 07:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOKX8-00031k-0l for emacs-devel@gnu.org; Sat, 26 Oct 2019 07:47:03 -0400 Original-Received: from sonic311-30.consmr.mail.ir2.yahoo.com ([77.238.176.162]:44038) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOKX7-00030w-Ev for emacs-devel@gnu.org; Sat, 26 Oct 2019 07:47:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1572090419; bh=Rky2Gj84vQD4fZysX0GLxf+U+Yk/Z6shmJGA57Ck7Pg=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=oPee2HVE/wSjGcmXkpC8kKzkOA9qu4j4Tr5XzD4R2vHz/Zy95w9Zq9L3lNUCVJy1Ph2ZwaT0O68GrJXYL/mNnk9QGK+G+1M22d3EFp7xX0/XroG33quSuWy0Pc63A4Q2SzFxV0oB/nelJTpSkr6NeUOxSI1SET/oT+x5yz5ZYWmq72h1MAMxVQ+/BjEhSFQG91yEePaFhsUmuIGqDBnGu+zqeGUHHyJHvxuV18LTB/wJJ9xTDDzCw8YNdxw5pJVFNeR+iGQdln9/z7JlKrQ0ah7xgRzr96mqcFZwK7hdTQ41C/v1wQEWjctelsBB5d4D/VwKNV2IRnRKz7q8X5zChw== X-YMail-OSG: CpZzfbMVM1kDASSRhIWUNR_1DUGWCu.mHGWSj2iVuhrgGxKBe8mzHwKpYG_JIf5 5qWseZLwxKyLGPYci11wpJSWi9OvamWjsyrb7a.kekHpDIOxtazOaRbhGjorcSZOQ1FvEgiKxrrK e8Bb.ZAsZtMiYKr1LIOWB0rKPiSy2a52acrtsM8sELq8Bj5WRw_PKDzfS1sQh.OagX9P_KmZcmGU GSow7LpH0U61ljJZm0pl3cxftB2ILum1yPRD0CVvNSExxIdaPV7Krr8fo6a.R8enL4V.5YSI6M0h enJ1i5DHPrc1poHSp.fpRlsCzoW3gPPBrsiWKunOcv2K4Zy8ytpCTK9YnuU5JUaYdKGCOhy4NznH sTRLktcSB3R6ni7P69881vWDtVvKPTR_SW.PFHYWX1lwNnFwjP7s2nkxplUgS8TkNMKiOQmmOjeb XYl3DfD.Q5X.jjQLwjgZXHfOzsB0CwWYc7rtUH1e1TLUlb.xka387YI.6JcL1vNR4Hr97_o_HLYF .xDTMvCqH22EshE19qhIovRsvg5YqIrHrpbOzC1.UYKvcuiyjAE0mhSzBB9MkQjRyQ5Kpf9r7aE6 7X.Sl7lzquzK3du_XCDw9IFh1Qu5OZB_GyVhbWQlAVnD4FHx1julwLT.ZcJ74tF9rbUb9IU4I0Uu PRCA.XCyYKhrDGF72lFOwrsQHMhm5VmQ3p6uE8NFB.vGt8u92AIA23bOIkHJNHEnxTpjKkH162UJ S_lXZHQozwgv4uX2udztW.x0s5l0aGkiClDzj.MdFschx0eGJZzIvfwswrOUZgG8_P8PKUr8sWt. clJSf8JE4oLdi6dr0VnzAsr9e6_3ZkfCnCI0Tp0D2F Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Sat, 26 Oct 2019 11:46:59 +0000 Original-Received: by smtp430.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID cf15c088447c490ac25c4f5d2fd0541f; Sat, 26 Oct 2019 11:46:59 +0000 (UTC) In-Reply-To: <87pnijkhrm.fsf@kenko.localhost.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.176.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241440 Archived-At: On October 26, 2019 10:55:41 AM GMT+02:00, Ingo Lohmar wrote: >On Sat, Oct 26 2019 03:49 (+0200), Ergus wrote: > >> Hi: >> >> I just added a branch `fix/inherit_extend_face` that fixes the issue >> with inheritance of the extend attribute with filter condition=2E >> >> There are two commits because I also detected another issue in gui I >> didn't see before because I don't use gui normally=2E >> >> Please give it a look and if everything is fine I'll move it to >master >> ASAP=2E > >Thanks, I just tried the branch and continued customizing my face >settings: No everything works as I would expect from inheritance=2E I >did >not see any adverse effects of the changes either, but I only used it >for about an hour=2E > Could you be more specific please? What is=2Enot working as you expect? >Looking forward to the changes being merged! > >BTW: there seem to be some whitespace-only hunks in the changes=2E=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E