From: Jim Porter <jporterbugs@gmail.com>
To: 61024@debbugs.gnu.org
Subject: bug#61024: 29.0.60; [PATCH] Eshell errors out when trying to redirect output of a remote process
Date: Sun, 22 Jan 2023 23:07:58 -0800 [thread overview]
Message-ID: <230f0e06-f47a-6a0d-93de-222ca16f7213@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
To see this in action, run "emacs -Q -f eshell" and then:
~ $ cd /sudo::
/sudo:root@host:~ # *echo hi there > #<foo>
Wrong type argument: "bufferp echo-stderr"
(Any other Tramp method should reproduce this issue.) That's because the
echo command is being redirected to two places: stdout is going to the
buffer "foo", and stderr is going to the Eshell buffer (via a pipe
process). However, that doesn't work for Tramp processes.
Attached is a fix with a test. I think this should definitely go in
Emacs 29, since it's a pretty bad regression. I'm actually surprised no
one has filed a bug on this already.
For tracking purposes, I believe this was broken by f07505d1ec (bug#21605).
For Emacs 30, it'd be interesting to see if there were a way to get
Tramp processes to have different targets for stdout and stderr. That'd
make them work a lot more like local processes in Eshell.
[-- Attachment #2: 0001-Don-t-try-to-make-a-pipe-process-for-remote-processe.patch --]
[-- Type: text/plain, Size: 2718 bytes --]
From 68febcf9f5e5999391e2ec7a8bb8f545b97ed7fe Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Sun, 22 Jan 2023 22:54:53 -0800
Subject: [PATCH] Don't try to make a pipe process for remote processes in
Eshell
Tramp currently isn't able to handle this, so the result will just
produce an error.
* lisp/eshell/esh-proc.el (eshell-gather-process-output): Check for a
remote 'default-directory' before trying to make a pipe process.
* test/lisp/eshell/esh-proc-tests.el
(esh-var-test/output/remote-redirect): New test.
---
lisp/eshell/esh-proc.el | 9 +++++++--
test/lisp/eshell/esh-proc-tests.el | 13 +++++++++++++
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el
index 9bae812c922..27cd521e82e 100644
--- a/lisp/eshell/esh-proc.el
+++ b/lisp/eshell/esh-proc.el
@@ -296,8 +296,13 @@ eshell-gather-process-output
'unix))))
(cond
((fboundp 'make-process)
- (unless (equal (car (aref eshell-current-handles eshell-output-handle))
- (car (aref eshell-current-handles eshell-error-handle)))
+ (unless (or ;; FIXME: It's not currently possible to use a
+ ;; stderr process for remote files.
+ (file-remote-p default-directory)
+ (equal (car (aref eshell-current-handles
+ eshell-output-handle))
+ (car (aref eshell-current-handles
+ eshell-error-handle))))
(eshell-protect-handles eshell-current-handles)
(setq stderr-proc
(make-pipe-process
diff --git a/test/lisp/eshell/esh-proc-tests.el b/test/lisp/eshell/esh-proc-tests.el
index ae7b1dddd69..8e02fbb5497 100644
--- a/test/lisp/eshell/esh-proc-tests.el
+++ b/test/lisp/eshell/esh-proc-tests.el
@@ -19,6 +19,7 @@
;;; Code:
+(require 'tramp)
(require 'ert)
(require 'esh-mode)
(require 'eshell)
@@ -85,6 +86,18 @@ esh-proc-test/output/stdout-and-stderr-to-buffer
"\\`\\'"))
(should (equal (buffer-string) "stdout\nstderr\n"))))
+(ert-deftest esh-var-test/output/remote-redirect ()
+ "Check that redirecting stdout for a remote process works."
+ (skip-unless (and (eshell-tests-remote-accessible-p)
+ (executable-find "echo")))
+ (let ((default-directory ert-remote-temporary-file-directory))
+ (eshell-with-temp-buffer bufname "old"
+ (with-temp-eshell
+ (eshell-match-command-output
+ (format "*echo hello > #<%s>" bufname)
+ "\\`\\'"))
+ (should (equal (buffer-string) "hello\n")))))
+
\f
;; Exit status
--
2.25.1
next reply other threads:[~2023-01-23 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 7:07 Jim Porter [this message]
2023-01-23 13:21 ` bug#61024: 29.0.60; [PATCH] Eshell errors out when trying to redirect output of a remote process Eli Zaretskii
2023-01-23 15:50 ` Michael Albinus
2023-01-23 17:47 ` Jim Porter
2023-01-23 17:51 ` Jim Porter
2023-01-23 18:25 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230f0e06-f47a-6a0d-93de-222ca16f7213@gmail.com \
--to=jporterbugs@gmail.com \
--cc=61024@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.