From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Date: Tue, 18 Jul 2023 03:34:06 +0300 Message-ID: <22ee6190-5946-9bde-b648-a55dd2188576@gutov.dev> References: <87bkgfjugn.fsf@catern.com> <83edlb3t0t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: sbaugh@janestreet.com, 62621@debbugs.gnu.org To: Eli Zaretskii , sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 18 02:35:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLYgU-0002s9-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Jul 2023 02:35:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLYgE-0001lk-3M; Mon, 17 Jul 2023 20:35:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLYgB-0001lY-49 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 20:35:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLYgA-0005Lq-RX for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 20:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLYg9-0005h1-RX for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 20:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 00:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62621 X-GNU-PR-Package: emacs Original-Received: via spool by 62621-submit@debbugs.gnu.org id=B62621.168964046221833 (code B ref 62621); Tue, 18 Jul 2023 00:35:01 +0000 Original-Received: (at 62621) by debbugs.gnu.org; 18 Jul 2023 00:34:22 +0000 Original-Received: from localhost ([127.0.0.1]:51215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLYfU-0005g4-G2 for submit@debbugs.gnu.org; Mon, 17 Jul 2023 20:34:22 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:41633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLYfP-0005fm-M8 for 62621@debbugs.gnu.org; Mon, 17 Jul 2023 20:34:19 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8BDD23200994; Mon, 17 Jul 2023 20:34:09 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 17 Jul 2023 20:34:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1689640449; x=1689726849; bh=Zwl2QplMMZVj6oajcNZeC//ylWGpyzK9Jgl i/1Q7HlY=; b=Eh0L61VZzPIgB3N9ICr20rbaqMtxpyKWF25HOrLGVd0ZJGaGaHq zhTOeHgHatbO/MIh+5CT6HX8i8prpibe1p0jS1/LgRQFltHekRJ6GeILqD41SZNO zqfKYHZgAs7EXl0kLWUe3sYpDr7T0oFcHUcDhBiZL5QlRxKoB+vmd+g2nllIslMq EvbXpg+9FNKW5Y7Oub9ziaVE4kdg9E7DMXowphu6ycQX/qTVTE/Gy/ccr9OdSxLA l9R17uimwPSRv3DavSDcpATqcj5mqKDo/tudo8DMY2xGyy5K/211OjBwn3DtgBws 83A+4ysrXK0xBmUQgRv+emdOM/o+S/5uWtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689640449; x=1689726849; bh=Zwl2QplMMZVj6oajcNZeC//ylWGpyzK9Jgl i/1Q7HlY=; b=Qsl86Xr7owTzEhJIGpQ2JbWN68tCKXeoWXaLrQU7oiKHHddg+OY d9nXOmMpHc/MfoKV53Xqqv3P+5mUs8pPF90remEWocwcXWQPQ+eg5Mu8qlpTStBb 0NleyiO+TNRCp8QWogLMwjg5s+dKK43Qn4v75WIiid/BD74zphtXB05P3i0Nj/bt 5CIEO/S6zEtNIt8kJW0oAPl8vr8ARKPihSzLMBquF4z9KPaS6m+vGuOZ66jrbY1c /9h1PLBWo+5SeLq8lzBfz4tnybUsm2+JdnuptH1s2hz3dXIOBXZdfAyAvODq+eUK ePfQVu9mZL86vDxQmuFHvNb+xKJoOfHdbxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgeefgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jul 2023 20:34:07 -0400 (EDT) Content-Language: en-US In-Reply-To: <83edlb3t0t.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265417 Archived-At: On 14/07/2023 09:29, Eli Zaretskii wrote: > IOW, we should NOT immediately generalize to > functions only because such generalization could make sense in some > use cases. I agree with that statement. When only one or two behaviors can be needed or foreseen, there's no hard need to make the option open-ended (which it becomes when it can be set to a function). This case, however, looks more like an exception to my eye. Similar to save-some-buffers-default-predicate where extensibility makes sense. And if you also wanted to avoid a direct reference to project-* in uniquify.el, that's another argument in favor of extensibility. > Repeat after me: Use options whose values are functions > are hard on our users, because they require them to be Lisp > programmers. That doesn't have to be the case. If the defcustom's docstring mentions several functions that can be used, and the :type widget includes them as well, the user can decide to switch to any of them without writing any Lisp (or having to understand the implementations). Examples: the aforementioned save-some-buffers-default-predicate, or project-prompter, or xref-history-storage, and so on.