all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Benjamin Orthen <benjamin@orthen.net>
Cc: 37256-done@debbugs.gnu.org
Subject: bug#37256: 27.0.50; Error (wrong-type-argument stringp nil) thrown when calling (load-theme 'solarized-dark t)
Date: Sun, 1 Sep 2019 09:59:53 -0700	[thread overview]
Message-ID: <22d98203-0d48-5a37-12dd-61f738ac96a0@cs.ucla.edu> (raw)
In-Reply-To: <83a7bo804h.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Eli Zaretskii wrote:

> Paul, I think this is because user-emacs-directory is now nil
> initially.

Yes, that's it. Thanks for reporting it. I installed the attached patch.

I looked for preloaded defcustoms with similar issues, but didn't find any.

[-- Attachment #2: 0001-Fix-load-theme-bug-with-user-emacs-directory.patch --]
[-- Type: text/x-patch, Size: 865 bytes --]

From ba12c5467dadd228a00bcf972fd8415c26f4a4bd Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@Penguin.CS.UCLA.EDU>
Date: Sun, 1 Sep 2019 09:56:40 -0700
Subject: [PATCH] Fix load-theme bug with user-emacs-directory

* lisp/custom.el (custom-theme-directory): Delay initialization,
since the value depends on user-emacs-directory (Bug#37256).
---
 lisp/custom.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/custom.el b/lisp/custom.el
index 9bd9712b65..2e42ea73c1 100644
--- a/lisp/custom.el
+++ b/lisp/custom.el
@@ -1137,6 +1137,7 @@ custom-theme-directory
 The command `customize-create-theme' writes theme files into this
 directory.  By default, Emacs searches for custom themes in this
 directory first---see `custom-theme-load-path'."
+  :initialize #'custom-initialize-delay
   :type 'string
   :group 'customize
   :version "22.1")
-- 
2.17.1


      reply	other threads:[~2019-09-01 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 15:07 bug#37256: 27.0.50; Error (wrong-type-argument stringp nil) thrown when calling (load-theme 'solarized-dark t) Benjamin Orthen
2019-09-01 16:14 ` Eli Zaretskii
2019-09-01 16:59   ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22d98203-0d48-5a37-12dd-61f738ac96a0@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=37256-done@debbugs.gnu.org \
    --cc=benjamin@orthen.net \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.