Hi Eli, this updated patch add the support for PHP var_modifier. Thanks. Vincenzo In data domenica 9 giugno 2024 22:36:35 CEST, Vincenzo Pupillo ha scritto: > Sorry. The correct patch is this one. I had forgotten to extend the commit by > adding documentation about the side effect. > Thanks. > Vincenzo > > In data domenica 9 giugno 2024 21:37:40 CEST, Vincenzo Pupillo ha scritto: > > In data domenica 9 giugno 2024 19:49:24 CEST, Eli Zaretskii ha scritto: > > > > From: Vincenzo Pupillo > > > > Cc: 71380@debbugs.gnu.org > > > > Date: Sun, 09 Jun 2024 19:23:05 +0200 > > > > > > > > > > > Thanks, but does this replace both patches you sent in a previous > > > > > > > message? See > > > > > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71380#23 > > > > > > > Or does this replace only one of the two, and the other one is > > > > > > > still > > > > > > > needed? > > > > > > > > > > > > Replace only one. The other is still needed. I made a separate > > > > > > patch, > > > > > > waiting to hear if I should open another bug for html-ts-mode. > > > > > > > > > > Would you mind posting both patches together, updated so that I could > > > > > install them both? And note that I just found a strange mistake(?) in > > > > > the second patch. > > > > > > > > > > Thanks. > > > > > > > > Hi Eli, > > > > sorry. I made a mistake with the second patch. > > > > The warning Andrea reported was actually due to the (require > > > > 'html-ts-mode) at the beginning of php-ts-mode. > > > > I then use a solution similar to elixir-ts-mode, the (require > > > > 'html-ts-mode) is done only after checking that the parser exists. > > > > > > But the patch you posted now doesn't include the HTML part, does it? > > > > > > is the patch self-contained, or does it still need the second patch? > > > > It is self-contained. You can delete the patch for html-ts-mode, it is no > > longer needed > > > > > > There is one problem I don't know how to solve: enabling php-ts-mode, > > > > because of the require html-ts-mode, the major mode for html changes > > > > from > > > > mhtml-mode to html-ts-mode. > > > > Can you tell me how to fix this? > > > > > > Just document this side effect, so that users know. > > > > Ok done. > > > > Thank you. > > Vincenzo > >