From: "Phillip Lord" <phillip.lord@russet.org.uk>
To: "Chris Gregory" <czipperz@gmail.com>, emacs-devel@gnu.org
Subject: Re: Reformat all of src/
Date: Wed, 28 Dec 2016 12:58:51 -0000 [thread overview]
Message-ID: <228ccc55affe1320a030a5652c63e005.squirrel@cloud103.planethippo.com> (raw)
In-Reply-To: <m237h864rw.fsf@newartisans.com>
On Wed, December 28, 2016 4:45 am, John Wiegley wrote:
>>>>>> "CG" == Chris Gregory <czipperz@gmail.com> writes:
>>>>>>
>
> CG> I found it irritating that there was inconsistent usage of tabs and
> spaces CG> at the beginning of lines. So I reformatted the entirety of the
> src CG> directory such that all lines that begin with 8 spaces now begin
> with CG> tabs, and all lines that begin with 1 tab and 8 spaces now begin
> with 2 CG> tabs, and so on.
>
>
> Hi Chris,
>
>
> I appreciate the other cleanup changes you've made, but I must reject
> this one. Feel free to fix whitespace along with other changes you make to
> a given area of code, but bulk changes like this do nothing but cure a
> problem people aren't having, while hurting our history and blame tools.
Why not patch up dir-locals.el to switch on whitespace.el, and highlight
bad spacing? At the moment, the spacing is inconsistent enough that I
don't know which spacing is considered correct and highlighting would help
to define this.
As Chris says, it's somewhat inconsistent at the moment, so copying nearby
lines doesn't really help.
FWIW (not very much) I think tabs suck...
next prev parent reply other threads:[~2016-12-28 12:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 0:59 Reformat all of src/ Chris Gregory
2016-12-28 3:43 ` Stefan Monnier
2016-12-28 4:45 ` John Wiegley
2016-12-28 4:52 ` Chris Gregory
2016-12-28 5:01 ` Chris Gregory
2016-12-28 12:58 ` Phillip Lord [this message]
2016-12-28 15:35 ` John Yates
2016-12-28 15:39 ` Lars Ingebrigtsen
2016-12-28 16:01 ` John Yates
2016-12-28 16:27 ` Lars Ingebrigtsen
2016-12-28 16:17 ` Phillip Lord
2016-12-28 17:19 ` Stefan Monnier
2016-12-28 17:35 ` Phillip Lord
2016-12-28 17:52 ` Stefan Monnier
2016-12-28 17:59 ` Eli Zaretskii
2016-12-28 16:32 ` Yuri Khan
2016-12-28 16:37 ` Lars Ingebrigtsen
2016-12-28 16:56 ` Yuri Khan
2016-12-28 16:59 ` John Wiegley
2016-12-28 17:12 ` Yuri Khan
2016-12-28 17:20 ` Phillip Lord
2016-12-28 18:38 ` Paul Eggert
2016-12-29 1:10 ` Dmitry Gutov
2016-12-29 5:53 ` Paul Eggert
2016-12-29 11:28 ` Dmitry Gutov
2016-12-30 1:07 ` Paul Eggert
2016-12-30 10:34 ` Phillip Lord
2017-01-01 1:14 ` Dmitry Gutov
2016-12-29 13:18 ` Phillip Lord
2016-12-29 16:17 ` Eli Zaretskii
2016-12-29 17:18 ` John Covici
2016-12-29 17:19 ` John Covici
2016-12-30 10:30 ` Phillip Lord
2016-12-28 17:23 ` John Yates
2016-12-31 10:23 ` Philippe Vaucher
2016-12-29 1:36 ` Richard Stallman
2016-12-29 3:41 ` Eli Zaretskii
2016-12-29 12:04 ` Tino Calancha
2016-12-29 16:15 ` Eli Zaretskii
2016-12-30 0:09 ` Richard Stallman
2016-12-30 8:21 ` Eli Zaretskii
2016-12-29 14:39 ` Stefan Monnier
2016-12-28 10:27 ` hector
-- strict thread matches above, loose matches on Subject: below --
2016-12-29 2:08 Chris Gregory
2016-12-29 3:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=228ccc55affe1320a030a5652c63e005.squirrel@cloud103.planethippo.com \
--to=phillip.lord@russet.org.uk \
--cc=czipperz@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.