* chmod update-game-score now causes fatal error @ 2017-03-24 13:44 Joseph Mingrone 2017-03-24 15:12 ` Paul Eggert 0 siblings, 1 reply; 4+ messages in thread From: Joseph Mingrone @ 2017-03-24 13:44 UTC (permalink / raw) To: emacs-devel [-- Attachment #1: Type: text/plain, Size: 696 bytes --] Hello, Supplying --with-gameuser=games:games (or --with-gameuser=games, --with-gameuser=:games, etc.) to configure causes an error when installing/staging as a user that doesn't have permission to change the ownership of the game files. This isn't new, but wasn't a problem for the FreeBSD port/package, because the permissions were handled by the package after staging. However, something has changed in the master branch and the error now causes the build to stop. Omitting --with-gameuser means files like update-game-score are not installed. Could these files somehow be installed without chmod, leaving that part for the package to deal with permissions after staging? Thanks, Joseph [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 930 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: chmod update-game-score now causes fatal error 2017-03-24 13:44 chmod update-game-score now causes fatal error Joseph Mingrone @ 2017-03-24 15:12 ` Paul Eggert 2017-03-24 18:00 ` Ulrich Mueller 0 siblings, 1 reply; 4+ messages in thread From: Paul Eggert @ 2017-03-24 15:12 UTC (permalink / raw) To: Joseph Mingrone, emacs-devel [-- Attachment #1: Type: text/plain, Size: 53 bytes --] Thanks for reporting that. I installed the attached. [-- Attachment #2: 0001-Don-t-require-chown-chgrp-for-game-installation.txt --] [-- Type: text/plain, Size: 2644 bytes --] From cbc518a5ece507c4d5214a06a9c1644852da8e74 Mon Sep 17 00:00:00 2001 From: Paul Eggert <eggert@cs.ucla.edu> Date: Fri, 24 Mar 2017 10:09:25 -0500 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20require=20chown/chgrp=20for=20g?= =?UTF-8?q?ame=20installation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem reported by Joseph Mingrone in: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00622.html * lib-src/Makefile.in (exp_archlibdir): Don’t fail if chown or chgrp fails with update-game-score and the game directory. Instead, expect the installer to fix this up afterwards. --- lib-src/Makefile.in | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index b2cd66c..086d0dc 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in @@ -266,7 +266,9 @@ need-blessmail: maybe-blessmail: $(BLESSMAIL_TARGET) ## Install the internal utilities. Until they are installed, we can -## just run them directly from lib-src. +## just run them directly from lib-src. When installing, do not give +## up if chown or chgrp fails, as the package responsible for +## installing Emacs can fix this problem later. $(DESTDIR)${archlibdir}: all @echo @echo "Installing utilities run internally by Emacs." @@ -283,15 +285,19 @@ $(DESTDIR)${archlibdir}: touch "$(DESTDIR)${gamedir}/snake-scores" \ "$(DESTDIR)${gamedir}/tetris-scores" ifneq (,$(gameuser)) - chown ${gameuser} "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chmod u+s,go-r "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chown ${gameuser} "$(DESTDIR)${gamedir}" - chmod u=rwx,g=rx,o=rx "$(DESTDIR)${gamedir}" + -chown ${gameuser} \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" \ + "$(DESTDIR)${gamedir}" && \ + chmod u+s,go-r \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + chmod u=rwx,g=rx,o=rx "$(DESTDIR)${gamedir}" else - chgrp ${gamegroup} "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chmod g+s,o-r "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chgrp ${gamegroup} "$(DESTDIR)${gamedir}" - chmod u=rwx,g=rwx,o=rx "$(DESTDIR)${gamedir}" + -chgrp ${gamegroup} \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + "$(DESTDIR)${gamedir}" && \ + chmod g+s,o-r \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + chmod u=rwx,g=rwx,o=rx "$(DESTDIR)${gamedir}" endif endif exp_archlibdir=`cd "$(DESTDIR)${archlibdir}" && /bin/pwd` && \ -- 2.9.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: chmod update-game-score now causes fatal error 2017-03-24 15:12 ` Paul Eggert @ 2017-03-24 18:00 ` Ulrich Mueller 2017-03-25 0:13 ` Noam Postavsky 0 siblings, 1 reply; 4+ messages in thread From: Ulrich Mueller @ 2017-03-24 18:00 UTC (permalink / raw) To: Paul Eggert; +Cc: Joseph Mingrone, emacs-devel >>>>> On Fri, 24 Mar 2017, Paul Eggert wrote: > Thanks for reporting that. I installed the attached. One && too much there: + -chgrp ${gamegroup} \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + "$(DESTDIR)${gamedir}" && \ + chmod g+s,o-r \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + chmod u=rwx,g=rwx,o=rx "$(DESTDIR)${gamedir}" ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: chmod update-game-score now causes fatal error 2017-03-24 18:00 ` Ulrich Mueller @ 2017-03-25 0:13 ` Noam Postavsky 0 siblings, 0 replies; 4+ messages in thread From: Noam Postavsky @ 2017-03-25 0:13 UTC (permalink / raw) To: Ulrich Mueller; +Cc: Joseph Mingrone, Paul Eggert, Emacs developers On Fri, Mar 24, 2017 at 2:00 PM, Ulrich Mueller <ulm@gentoo.org> wrote: > > One && too much there: > > + -chgrp ${gamegroup} \ > + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ > + "$(DESTDIR)${gamedir}" && \ > + chmod g+s,o-r \ > + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ > + chmod u=rwx,g=rwx,o=rx "$(DESTDIR)${gamedir}" > Fixed [1: 21d4db3e81]. 1: 2017-03-24 20:09:58 -0400 21d4db3e816ed7aa6424f632283253db59f5a275 ; lib-src/Makefile.in (exp_archlibdir): Drop extra '&&' from previous commit ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-25 0:13 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-03-24 13:44 chmod update-game-score now causes fatal error Joseph Mingrone 2017-03-24 15:12 ` Paul Eggert 2017-03-24 18:00 ` Ulrich Mueller 2017-03-25 0:13 ` Noam Postavsky
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.