From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: daanturo Newsgroups: gmane.emacs.bugs Subject: bug#56355: 29.0.50; Implement file-parent-directory Date: Thu, 1 Sep 2022 11:11:31 +0700 Message-ID: <226bfba3-d76d-9b32-9527-c8ec8c556a15@gmail.com> References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------NTKTv6uB9KZEeCQDSgQtPZDV" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1039"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 To: 56355@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 01 06:15:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTbcG-00009L-6e for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Sep 2022 06:15:44 +0200 Original-Received: from localhost ([::1]:54098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTbcE-0006fl-Tt for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Sep 2022 00:15:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTbbb-0006LA-3m for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTbba-0006HT-GM for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTbba-0006xA-0z for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: daanturo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Sep 2022 04:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56355 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166200564926645 (code B ref -1); Thu, 01 Sep 2022 04:15:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Sep 2022 04:14:09 +0000 Original-Received: from localhost ([127.0.0.1]:40843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTbaj-0006vh-6f for submit@debbugs.gnu.org; Thu, 01 Sep 2022 00:14:09 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTbad-0006vU-FA for submit@debbugs.gnu.org; Thu, 01 Sep 2022 00:14:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTbad-0005D7-4P for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:14:03 -0400 Original-Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:34568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTbab-0006BS-0H for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 00:14:02 -0400 Original-Received: by mail-pg1-x533.google.com with SMTP id 73so6906455pga.1 for ; Wed, 31 Aug 2022 21:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc; bh=tR0m9rfeAnweVjHgDRud5LYoM9tpoR1tMKik8HodMJE=; b=P8nrOMv94qqVbgM4WrFMob92lKBSEJcy66eWficnFjHq5G+N7EEX+NYpCBVYhuMmW/ /f4SezshtClFq1ZELtevCOGYmrZsuNJhynul2aDRwhkO5qQQVuyFa7UUSlzR5rEihl4u m77roIALCwhlwXMaK6vEZ1LcxvkYVYPN5wSY+/NLBYOqBNwvcC69FgOEfiZnSV6GukJ4 VdMqlkMprHQLe5+gWm5ZEjGO6/2lGyaRTHn8e7j1OpYJOP2CEem6wZwk2kTDMSM9EWz3 Sn/O8nH0y04I6K2CVV2VeIXQvML1yYt5Oshg3yWfYPIjI1ciw82pQwYmS3vGyrA9Cse/ 1puw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc; bh=tR0m9rfeAnweVjHgDRud5LYoM9tpoR1tMKik8HodMJE=; b=vsnLqNLVXqWKRfNIUz5Dzv2BbjPX8MDMFAC6uwBwcpt04Qd39/SaBWhZwTCqRFj3hF wP+dlB/iByTObJIrAzQCD/dpVLoB7UiXdK0QXuW/3ClmaCY9fkoG7s9dn/D39bnNOlV9 81snNys7o2+7Dm89z50XpOD+LlPVcB9nweuWhaCgDGfFL6ZTeiKs3eFmKGLTh/ATfuhy hzgDU18BDXgeGCekmnmcRf1hdocr5ZmMX5AZDTcNqUqDPhY3OgjuxCBygA/F76RO7y98 gdt9j+g/pJEFLH3Gqb1hede0IjwtTQ2kSQAjM6qizIlinOtgK5nGyNGFfrw6epf0dFPK 5iOw== X-Gm-Message-State: ACgBeo0k141ncdzEvYOw4wHmhNODMzcaZgIA9nvrDw+N8U01Pg1xJyTW ie2+IJ2Spog/tb79826TWLoIgtoe1zs= X-Google-Smtp-Source: AA6agR7psKvWaAuj5aDgl0q4Wn9ZlJT2dhBcJ6t77qGVPWEak92ZQLUV+k2zgTxSVGsZkmR0/WLdeQ== X-Received: by 2002:a63:d84e:0:b0:42b:5834:fd73 with SMTP id k14-20020a63d84e000000b0042b5834fd73mr24039794pgj.506.1662005638493; Wed, 31 Aug 2022 21:13:58 -0700 (PDT) Original-Received: from [192.168.1.3] ([123.20.211.253]) by smtp.gmail.com with ESMTPSA id h15-20020a170902f7cf00b00174de2bb5f3sm6802440plw.132.2022.08.31.21.13.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 21:13:57 -0700 (PDT) Content-Language: en-US In-Reply-To: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=daanturo@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241226 Archived-At: This is a multi-part message in MIME format. --------------NTKTv6uB9KZEeCQDSgQtPZDV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the case of a circular symlink, technically it's still correct to return non-nil. ``` ls -l /tmp/foo total 0 lrwxrwxrwx 1 me me 9 Sep  1 10:59 foo -> /tmp/foo/ ``` In this case: ``` ;;; because (file-equal-p "/tmp/foo/foo/" "/tmp/foo/") => t ;;; therefore (my-parent-directory "/tmp/foo/foo/") ; (the equal version) => "/tmp/foo/" (file-parent-directory "/tmp/foo/foo/") => nil ``` Obviously, the `equal` version fits our expectation better, although that's a mistake at the time of link creation, "/tmp/foo/foo"'s parent still exists and not a nil value. Not to mention `file-equal-p` needs an active TRAMP connection for remote files. -- Daanturo. --------------NTKTv6uB9KZEeCQDSgQtPZDV Content-Type: text/x-patch; charset=UTF-8; name="0001-Change-file-parent-directory-s-behavior.patch" Content-Disposition: attachment; filename="0001-Change-file-parent-directory-s-behavior.patch" Content-Transfer-Encoding: base64 RnJvbSA3NmRjZDE4MTRhZmQyYWU1YjgzYjQzNzkwZDU0ZTM1MTU3N2Q2MjQ5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYWFudHVybyA8ZGFhbnR1cm9AZ21haWwuY29tPgpE YXRlOiBUaHUsIDEgU2VwIDIwMjIgMDk6NDI6MDUgKzA3MDAKU3ViamVjdDogW1BBVENIXSBD aGFuZ2UgZmlsZS1wYXJlbnQtZGlyZWN0b3J5J3MgYmVoYXZpb3IKCiogbGlzcC9maWxlcy5l bCAoZmlsZS1wYXJlbnQtZGlyZWN0b3J5KTogdXNlIGVxdWFsIGluc3RlYWQgb2YKZmlsZS1l cXVhbC1wIHRvIGNvbXBhcmUgdGhlIGZvdW5kIHBhcmVudCBhbmQgdGhlIGNoaWxkCi0tLQog bGlzcC9maWxlcy5lbCB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZmlsZXMuZWwgYi9saXNwL2Zp bGVzLmVsCmluZGV4IDc0MGUwOTA1NWIuLmIwODRkY2E4YjcgMTAwNjQ0Ci0tLSBhL2xpc3Av ZmlsZXMuZWwKKysrIGIvbGlzcC9maWxlcy5lbApAQCAtNTE5Niw3ICs1MTk2LDkgQEAgdG8g YGRlZmF1bHQtZGlyZWN0b3J5JywgYW5kIHRoZSByZXN1bHQgd2lsbCBhbHNvIGJlIHJlbGF0 aXZlLiIKICAgICAoY29uZAogICAgICA7OyBmaWxlbmFtZSBpcyBhdCB0b3AtbGV2ZWwsIHRo ZXJlZm9yZSBubyBwYXJlbnQKICAgICAgKChvciAobnVsbCBwYXJlbnQpCi0gICAgICAgICAg KGZpbGUtZXF1YWwtcCBwYXJlbnQgZXhwYW5kZWQtZmlsZW5hbWUpKQorICAgICAgICAgIDs7 IGBlcXVhbCcgaXMgZW5vdWdoLCB3ZSBkb24ndCBuZWVkIHRvIHJlc29sdmUgc3ltbGlua3Mg aGVyZQorICAgICAgICAgIDs7IHdpdGggYGZpbGUtZXF1YWwtcCcsIGFsc28gZm9yIHBlcmZv cm1hbmNlCisgICAgICAgICAgKGVxdWFsIHBhcmVudCBleHBhbmRlZC1maWxlbmFtZSkpCiAg ICAgICBuaWwpCiAgICAgIDs7IGZpbGVuYW1lIGlzIHJlbGF0aXZlLCByZXR1cm4gcmVsYXRp dmUgcGFyZW50CiAgICAgICgobm90IChmaWxlLW5hbWUtYWJzb2x1dGUtcCBmaWxlbmFtZSkp Ci0tIAoyLjM3LjMKCg== --------------NTKTv6uB9KZEeCQDSgQtPZDV--