From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60210: 30.0.50; tab-bar height not recalculated when face changes Date: Sun, 01 Jan 2023 17:56:36 +0000 Message-ID: <226b32f79feedbfa05f1@heytings.org> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8982"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60210@debbugs.gnu.org To: Juri Linkov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 18:57:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC2aF-00029B-Rl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 18:57:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC2a0-0003c0-NU; Sun, 01 Jan 2023 12:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC2Zy-0003bW-Mv for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC2Zy-00088B-ED for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC2Zy-0004ov-AI for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60210 X-GNU-PR-Package: emacs Original-Received: via spool by 60210-submit@debbugs.gnu.org id=B60210.167259579918491 (code B ref 60210); Sun, 01 Jan 2023 17:57:02 +0000 Original-Received: (at 60210) by debbugs.gnu.org; 1 Jan 2023 17:56:39 +0000 Original-Received: from localhost ([127.0.0.1]:41675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2Zb-0004oB-4e for submit@debbugs.gnu.org; Sun, 01 Jan 2023 12:56:39 -0500 Original-Received: from heytings.org ([95.142.160.155]:54678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2ZZ-0004o3-Fv for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 12:56:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672595796; bh=ehbaMcosPQUk7TJx3iScjBaGb+8EV1uRHzxHjPLpEPw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ipAtGMjGVyxu5soK5QLF2TczjWpk6PdepC5autClu3ojXGygBZ9TEAB3AfOLUSQ6k QZ+egWjLpIVsUUq76ZrbRGww3oM34yLFUHagMzyazHDsoNjj2WzrtPXCtO8XS9XWZB 9Q0vcq0CibpiVncW95sRhJd4ET6Qo95La4oC5Xl0aOMmz3Gq5RCnX5+8eLkNrdGrp7 OfLswzTUI7K1FL3Zg8r6ngN8KbngvSEVyNf6owfj9iq2STxJovVZeXeManMNur5iXB XUxub/sPCtxLmQpgedoOfJh5ttWnEyjx2d3KDbuVsnTo+Fn6JjPQaYFDYCfH4pBDKx Hl09IAH0sZWBQ== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252264 Archived-At: > > Thanks! Pushed (b14bbd108e), and closing. > I got (privately) an interesting bug report about this commit. The bug is that, because of this change, the tab-bar is not displayed anymore (or is displayed but stays empty) in certain circumstances. It's a font-related bug again, so it might be difficult to reproduce. On my system, (set-face-attribute 'default nil :font "JetBrains Mono") (tab-bar-mode 1) triggers the bug. The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the height of the default face, which is 39 pixels, whereas new_height, which is computed with tab_bar_height, uses the font of the tab-bar face (variable-pitch in emacs -Q). On my system, new_height is (with a single *scratch* tab) 36 pixels. Therefore new_height < WINDOW_PIXEL_HEIGHT (w), when in fact according to the logic of the code we should have new_height == WINDOW_PIXEL_HEIGHT (w).