all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Gregory Heytings <gregory@heytings.org>
To: Juri Linkov <juri@linkov.net>, Eli Zaretskii <eliz@gnu.org>
Cc: 60210@debbugs.gnu.org
Subject: bug#60210: 30.0.50; tab-bar height not recalculated when face changes
Date: Sun, 01 Jan 2023 17:56:36 +0000	[thread overview]
Message-ID: <226b32f79feedbfa05f1@heytings.org> (raw)
In-Reply-To: <f9fdb7b870a2b753780d@heytings.org>


>
> Thanks!  Pushed (b14bbd108e), and closing.
>

I got (privately) an interesting bug report about this commit.  The bug is 
that, because of this change, the tab-bar is not displayed anymore (or is 
displayed but stays empty) in certain circumstances.  It's a font-related 
bug again, so it might be difficult to reproduce.  On my system,

(set-face-attribute 'default nil :font "JetBrains Mono")
(tab-bar-mode 1)

triggers the bug.

The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the 
height of the default face, which is 39 pixels, whereas new_height, which 
is computed with tab_bar_height, uses the font of the tab-bar face 
(variable-pitch in emacs -Q).  On my system, new_height is (with a single 
*scratch* tab) 36 pixels.  Therefore new_height < WINDOW_PIXEL_HEIGHT (w), 
when in fact according to the logic of the code we should have new_height 
== WINDOW_PIXEL_HEIGHT (w).






  reply	other threads:[~2023-01-01 17:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 23:04 bug#60210: 30.0.50; tab-bar height not recalculated when face changes Gabriel do Nascimento Ribeiro
2022-12-25  8:35 ` Juri Linkov
2022-12-25  9:29   ` Eli Zaretskii
2022-12-26  0:24     ` Gregory Heytings
2022-12-26 12:23       ` Eli Zaretskii
2022-12-26 13:36         ` Gregory Heytings
2022-12-26 17:29           ` Juri Linkov
2022-12-26 17:40             ` Gregory Heytings
2023-01-01 17:56               ` Gregory Heytings [this message]
2023-01-01 18:22                 ` Eli Zaretskii
2023-01-01 21:50                   ` Gregory Heytings
2023-01-02  3:29                     ` Eli Zaretskii
2023-01-02 15:05                     ` Eli Zaretskii
2023-01-02 15:28                       ` Gregory Heytings
2023-01-02 16:53                         ` Eli Zaretskii
2023-01-04 13:53                           ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=226b32f79feedbfa05f1@heytings.org \
    --to=gregory@heytings.org \
    --cc=60210@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.