From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last Date: Sun, 01 Jan 2023 16:59:37 +0000 Message-ID: <226b32f79fe1e154cfb4@heytings.org> References: <87358u5y6l.fsf@daniel-mendler.de> <226b32f79f2d431d75b6@heytings.org> <009141ba-c21a-a5cb-a81b-c72a12a26207@daniel-mendler.de> <226b32f79f728e6bfed4@heytings.org> <82cf05e4-3c3f-9804-4801-eb31988f6d7d@daniel-mendler.de> <226b32f79f325daf9c7a@heytings.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Gv7UoeGtTO" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2483"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60464@debbugs.gnu.org To: Daniel Mendler , Jim Porter , Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 18:00:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC1hH-0000Sz-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 18:00:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC1h4-00070b-Tp; Sun, 01 Jan 2023 12:00:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC1gp-0006yS-D3 for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC1go-0007mq-Vy for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC1go-0003Ah-S6 for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60464 X-GNU-PR-Package: emacs Original-Received: via spool by 60464-submit@debbugs.gnu.org id=B60464.167259238112125 (code B ref 60464); Sun, 01 Jan 2023 17:00:02 +0000 Original-Received: (at 60464) by debbugs.gnu.org; 1 Jan 2023 16:59:41 +0000 Original-Received: from localhost ([127.0.0.1]:41600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC1gT-00039U-C0 for submit@debbugs.gnu.org; Sun, 01 Jan 2023 11:59:41 -0500 Original-Received: from heytings.org ([95.142.160.155]:54562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC1gR-00039L-QM for 60464@debbugs.gnu.org; Sun, 01 Jan 2023 11:59:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672592378; bh=XpFjFx9hO3D+hldRaDMlaK70EGyET8zQojpylB3sXh0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=1R4REtF+q6jPB/sKZBJoPZ1YZvxMEggqKRvEM3GMGzJzeKKtPwNXpztVvJko/JVUH Vu+oxcBTLawBwKs0lG4lTM5wG43I1Zj957Ef7MD2Zfr4nTG/2hpQSCaKo8zBRjAOSR 5DSMEzL0FaJfBTfB/q0yTBPpnIL6f64cNQJCVMf/4QqDD8nehHVudPnDyKladOFEC7 J53Iq6Rb9zVXQP55DoCsxbfhUNVMEgwReHR227r/lUGXZiOcs2DVX8bmSVr0/Yvrkw A+smktMaJEuinG/PkwRq+qmiYpCj6yZ3qMSosZnJC7oQTC0ASV3JB28TslrDjSwYU0 QU/u2gqVCQnOg== In-Reply-To: <226b32f79f325daf9c7a@heytings.org> Content-ID: <226b32f79f7b63c72c63@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252252 Archived-At: --Gv7UoeGtTO Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: <226b32f79f711c08a996@heytings.org> After working a bit more on this bug, I concluded that what Stefan initially suggested, to use the string representation of the value, is safer than trying to extract the string corresponding to the argument that the user typed in from the command line. But that's not the end of the story. The problem is that, IIUC, in Eshell, in a directory with .el files and without .EL files: (1) ls *.el TAB should display all these files in *Completions* (2) ls *.EL TAB should say "No match" (3) ls *.el SPC TAB should display all files (not just the .el ones) in *Completions* (4) ls *.EL SPC TAB should display all files (not just the .el ones) in *Completions* IOW, sometimes pcomplete-arg should in fact return a list and not a single string value, because that's what Eshell expects (case (1) above), and sometimes it shouldn't. According to my tests, a non-string value can be returned if and only if index is 'last'. Hopefully, this is also what other users of pcomplete expect. Can you please test the attached patch as extensively as possible, and report if you see regressions? Jim, can you also try the patch and report if you see regressions? Stefan and Eli, does that patch look right to you? Thanks. --Gv7UoeGtTO Content-Type: text/x-diff; name=Further-improvement-for-non-string-values-in-pcomple.patch; charset=us-ascii Content-Transfer-Encoding: base64 Content-ID: <226b32f79f103462b3e6@heytings.org> Content-Disposition: attachment; filename=Further-improvement-for-non-string-values-in-pcomple.patch RnJvbSBlZTI4NzcwMThiMWNkYjkzZjExZmZmYzg5YjlkZDRlZDQ2MWZjYzk2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTdW4sIDEgSmFu IDIwMjMgMTY6NDc6MzYgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gRnVydGhl ciBpbXByb3ZlbWVudCBmb3Igbm9uLXN0cmluZyB2YWx1ZXMgaW4gcGNvbXBs ZXRlDQoNCiogbGlzcC9wY29tcGxldGUuZWwgKHBjb21wbGV0ZS1hcmcpOiBV c2UgdGhlIHN0cmluZyByZXByZXNlbnRhdGlvbg0Kb2YgdGhlIGFyZ3VtZW50 IHZhbHVlIGluc3RlYWQgb2YgdGhlIHRleHQgcmVwcmVzZW50YXRpb24gb2Yg dGhlDQphcmd1bWVudC4gIFJldHVybiB0aGUgdmFsdWUsIGV2ZW4gd2hlbiBp dCBpcyBub3QgYSBzdHJpbmcsIHdoZW4NCmluZGV4IGlzICdsYXN0Jy4gIEZp eGVzIGJ1ZyM2MDQ2NC4NCi0tLQ0KIGxpc3AvcGNvbXBsZXRlLmVsIHwgMTYg KysrKysrKy0tLS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlv bnMoKyksIDkgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9saXNwL3Bj b21wbGV0ZS5lbCBiL2xpc3AvcGNvbXBsZXRlLmVsDQppbmRleCA1YmVlNTE1 MjQ2Li5iY2U5YWE1YjRkIDEwMDY0NA0KLS0tIGEvbGlzcC9wY29tcGxldGUu ZWwNCisrKyBiL2xpc3AvcGNvbXBsZXRlLmVsDQpAQCAtNjQ4LDEwICs2NDgs MTAgQEAgcGNvbXBsZXRlLWFyZw0KIGFjY2Vzc2luZyBhYnNvbHV0ZSBhcmd1 bWVudCBwb3NpdGlvbnMuDQogDQogV2hlbiB0aGUgYXJndW1lbnQgaGFzIGJl ZW4gdHJhbnNmb3JtZWQgaW50byBzb21ldGhpbmcgdGhhdCBpcyBub3QNCi1h IHN0cmluZyBieSBgcGNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cy1mdW5jdGlv bicsIHRoZSB0ZXh0DQotcmVwcmVzZW50YXRpb24gb2YgdGhlIGFyZ3VtZW50 LCBuYW1lbHkgd2hhdCB0aGUgdXNlciBhY3R1YWxseQ0KLXR5cGVkIGluLCBp cyByZXR1cm5lZCwgYW5kIHRoZSB2YWx1ZSBvZiB0aGUgYXJndW1lbnQgaXMg c3RvcmVkIGluDQotdGhlIHBjb21wbGV0ZS1hcmctdmFsdWUgdGV4dCBwcm9w ZXJ0eSBvZiB0aGF0IHN0cmluZy4iDQorYSBzdHJpbmcgYnkgYHBjb21wbGV0 ZS1wYXJzZS1hcmd1bWVudHMtZnVuY3Rpb24nIGFuZCBJTkRFWCBpcyBub3QN CitgbGFzdCcsIHRoZSBzdHJpbmcgcmVwcmVzZW50YXRpb24gb2YgdGhhdCB2 YWx1ZSBpcyByZXR1cm5lZCwgYW5kDQordGhlIHZhbHVlIGlzIHN0b3JlZCBp biB0aGUgcGNvbXBsZXRlLWFyZy12YWx1ZSB0ZXh0IHByb3BlcnR5IG9mDQor dGhhdCBzdHJpbmcuIg0KICAgKGxldCAoKGFyZw0KICAgICAgICAgIChudGgg KCsgKHBjYXNlIGluZGV4DQogCSAgICAgICAgICAgKCdmaXJzdCAwKQ0KQEAg LTY1OSwxMiArNjU5LDEwIEBAIHBjb21wbGV0ZS1hcmcNCiAJICAgICAgICAg ICAoXyAgICAgICgtIHBjb21wbGV0ZS1pbmRleCAob3IgaW5kZXggMCkpKSkN CiAJICAgICAgICAgKG9yIG9mZnNldCAwKSkNCiAgICAgICAgICAgICAgIHBj b21wbGV0ZS1hcmdzKSkpDQotICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAg IChpZiAob3IgKHN0cmluZ3AgYXJnKQ0KKyAgICAgICAgICAgIChlcSBpbmRl eCAnbGFzdCkpDQogICAgICAgICBhcmcNCi0gICAgICAocHJvcGVydGl6ZQ0K LSAgICAgICAoYnVmZmVyLXN1YnN0cmluZyAocGNvbXBsZXRlLWJlZ2luIGlu ZGV4IG9mZnNldCkNCi0gICAgICAgICAgICAgICAgICAgICAgICAgKHBjb21w bGV0ZS1iZWdpbiAoMS0gKG9yIGluZGV4IDApKSBvZmZzZXQpKQ0KLSAgICAg ICAncGNvbXBsZXRlLWFyZy12YWx1ZSBhcmcpKSkpDQorICAgICAgKHByb3Bl cnRpemUgKGZvcm1hdCAiJVMiIGFyZykgJ3Bjb21wbGV0ZS1hcmctdmFsdWUg YXJnKSkpKQ0KIA0KIChkZWZ1biBwY29tcGxldGUtYmVnaW4gKCZvcHRpb25h bCBpbmRleCBvZmZzZXQpDQogICAiUmV0dXJuIHRoZSBiZWdpbm5pbmcgcG9z aXRpb24gb2YgdGhlIElOREVYdGggYXJndW1lbnQuDQotLSANCjIuMzkuMA0K DQo= --Gv7UoeGtTO--