From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs Subject: bug#22978: 25.0.92; log-view-diff: TMM required for non-consecutive revisions Date: Thu, 10 Mar 2016 12:12:15 -0500 Organization: Modular Genetics Inc. Message-ID: <22241.43759.289350.874836@gargle.gargle.HOWL> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1457630013 4125 80.91.229.3 (10 Mar 2016 17:13:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Mar 2016 17:13:33 +0000 (UTC) To: 22978@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 10 18:13:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ae499-0007CO-8d for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Mar 2016 18:13:11 +0100 Original-Received: from localhost ([::1]:50021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae498-0004wl-H1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Mar 2016 12:13:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae494-0004wI-UM for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:13:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae490-0004uJ-8K for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:13:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae490-0004uF-4X for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1ae48z-0005dR-Uq for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Mar 2016 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145762995021611 (code B ref -1); Thu, 10 Mar 2016 17:13:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Mar 2016 17:12:30 +0000 Original-Received: from localhost ([127.0.0.1]:44027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1ae48U-0005cV-5u for submit@debbugs.gnu.org; Thu, 10 Mar 2016 12:12:30 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52527) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1ae48T-0005cI-4Q for submit@debbugs.gnu.org; Thu, 10 Mar 2016 12:12:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae48M-0004gm-SQ for submit@debbugs.gnu.org; Thu, 10 Mar 2016 12:12:23 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae48M-0004gi-PX for submit@debbugs.gnu.org; Thu, 10 Mar 2016 12:12:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae48L-0004rc-BY for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:12:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae48I-0004gW-3F for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:12:21 -0500 Original-Received: from [198.0.172.193] (port=41408 helo=granada.modulargenetics.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae48H-0004gS-Vr for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 12:12:18 -0500 Original-Received: from persepolis.modulargenetics.com (persepolis.modulargenetics.com [192.168.23.34]) by granada.modulargenetics.com (Postfix on SuSE Linux) with ESMTP id 625391108A6 for ; Thu, 10 Mar 2016 12:12:15 -0500 (EST) Original-Received: by persepolis.modulargenetics.com (Postfix on SuSE Linux, from userid 503) id 50D0887472; Thu, 10 Mar 2016 12:12:15 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114717 Archived-At: 1. "emacs -Q" in a current Emacs working copy. 2. "C-x C-f BUGS RET" 3. "C-x v l" to create its log buffer. 4. "M-x transient-mark-mode RET" to disable transient mark mode. 5. "n n n M-<" to mark the fourth most recent commit (for me this is 19b9c46 by Julien Danjou on Dec 3 2010) and move point back to the most recent commit. 6. "=" to get a diff. This will show a hunk starting with the deleted line "You can read the read the ..." which is just the most recent revision. 7. Type "M-x transient-mark-mode RET" and then "C-x o =" to show the expected diff between the two selected revisions. If mark is on the same commit, this will include the whole file. The documentation for log-view-diff implies that this is the correct behavior (since the region is perpetually inactive if TMM is disabled), but this is extremely non-featureful, as there is then no way to find the diff between two non-consecutive revisions without enabling TMM. The patch included at the bottom restores the original behavior for us non-TMM users while keeping TMM behavior. The behavior is the same in 25.0.92 and a recent repo version; both configuration summaries are included. The patch was developed in 25.0.92 and the instructions above in the repo. -- Bob Rogers Modular Genetics Inc. http://www.modulargenetics.com/ ================ In GNU Emacs 25.0.92.1 (x86_64-suse-linux-gnu, GTK+ Version 2.24.28) of 2016-03-04 built on persepolis Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-pop --without-dbus --prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man --sharedstatedir=/var/lib --libexecdir=/usr/lib --with-x --with-xpm=no --with-jpeg --with-tiff --with-gif=no --with-png --with-x-toolkit=yes --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib64 --build x86_64-suse-linux 'CFLAGS=-g -O2 -fno-optimize-sibling-calls' LDFLAGS=-s' Configured features: JPEG TIFF PNG RSVG SOUND GSETTINGS NOTIFY FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=local locale-coding-system: utf-8-unix ================ In GNU Emacs 25.1.50.1 (x86_64-suse-linux-gnu, GTK+ Version 2.24.28) of 2016-03-06 built on orion Repository revision: 7882dc625e1ec562fcd0e1b743ef11b160cae18e Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured features: XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix ================ diff -u --label /usr/share/emacs/25.0.92/lisp/vc/log-view.el.gz --label \#\ /tmp/rogers/jka-com15891oVD /tmp/rogers/buffer-content-15891CqP --- /usr/share/emacs/25.0.92/lisp/vc/log-view.el.gz +++ # @@ -591,7 +591,9 @@ file(s)." (interactive (list (if (use-region-p) (region-beginning) (point)) - (if (use-region-p) (region-end) (point)))) + (if (use-region-p) + (region-end) + (or (and (not transient-mark-mode) (mark)) (point))))) (log-view-diff-common beg end)) (defun log-view-diff-changeset (beg end) Diff finished. Thu Mar 10 12:01:03 2016