From: Drew Adams <drew.adams@oracle.com>
To: "Paul Eggert" <eggert@cs.ucla.edu>, "João Távora" <joaotavora@gmail.com>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
Pip Cet <pipcet@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: RE: 31395511: "Don’t attempt to modify constant strings"
Date: Thu, 4 Jun 2020 14:21:02 -0700 (PDT) [thread overview]
Message-ID: <220a649e-98c8-4011-9dd9-77abcdc8b3f2@default> (raw)
In-Reply-To: <1ce4b8e1-c452-a11f-1146-dc54342abc9b@cs.ucla.edu>
> In that case perhaps all that's needed is to document the issue with
> make-text-button, at least unless someone comes up with a cleaner API.
Apologies for not following this thread.
I have code that uses `make-text-button'.
What is it, exactly that must not be done
by a user?
___
1. In help-fns+.el I pass a string as first arg
that results from `copy-sequence' of a key
description.
2. In finder+.el I pass a `help-echo' value
that's a literal string.
3. In facemenu+.el I pass a `mouse-face' value
that's a list with a `:foreground' value
that's a literal string.
I'm guessing that you're talking only about
passing a literal string as the first arg
(so only #1 above). Is that right? If so,
is my #1 problematic?
next prev parent reply other threads:[~2020-06-04 21:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 21:52 31395511: "Don’t attempt to modify constant strings" João Távora
2020-06-03 22:41 ` Paul Eggert
2020-06-03 22:52 ` Pip Cet
2020-06-03 23:20 ` Paul Eggert
2020-06-03 23:20 ` Basil L. Contovounesios
2020-06-03 22:41 ` Pip Cet
2020-06-03 23:08 ` Basil L. Contovounesios
2020-06-03 23:31 ` Basil L. Contovounesios
2020-06-03 23:48 ` João Távora
2020-06-04 0:43 ` Paul Eggert
2020-06-04 1:19 ` Paul Eggert
2020-06-04 7:26 ` Pip Cet
2020-06-04 11:11 ` Basil L. Contovounesios
2020-06-04 19:46 ` Paul Eggert
2020-06-04 20:25 ` João Távora
2020-06-04 20:29 ` Paul Eggert
2020-06-04 21:21 ` Drew Adams [this message]
2020-06-04 20:43 ` Pip Cet
2020-06-04 21:27 ` Stefan Monnier
2020-06-04 21:42 ` Pip Cet
2020-06-04 23:10 ` Paul Eggert
2020-06-05 2:09 ` Clément Pit-Claudel
2020-06-05 6:44 ` Paul Eggert
2020-06-05 12:44 ` Stefan Monnier
2020-06-05 17:01 ` Drew Adams
2020-06-05 9:48 ` Pip Cet
2020-06-05 18:37 ` Paul Eggert
2020-06-04 22:33 ` Basil L. Contovounesios
2020-06-05 15:25 ` João Távora
2020-06-05 17:14 ` Dmitry Gutov
2020-06-05 23:19 ` João Távora
2020-06-05 23:32 ` Dmitry Gutov
2020-06-06 1:34 ` FW: " Drew Adams
2020-06-06 0:23 ` Drew Adams
2020-06-06 1:43 ` Paul Eggert
2020-06-06 4:06 ` Richard Stallman
2020-06-06 11:41 ` João Távora
2020-06-06 11:47 ` João Távora
2020-06-04 4:38 ` Pip Cet
2020-06-04 9:31 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220a649e-98c8-4011-9dd9-77abcdc8b3f2@default \
--to=drew.adams@oracle.com \
--cc=contovob@tcd.ie \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.