From: "Drew Adams" <drew.adams@oracle.com>
To: 13764@debbugs.gnu.org
Subject: bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)'
Date: Mon, 18 Feb 2013 09:24:46 -0800 [thread overview]
Message-ID: <220CC265C06944E69F89E1F29796C873@us.oracle.com> (raw)
These are not tiny, trivial functions.
They do not fit the criteria for `defsubst' outlined in (elisp)
`Inline Functions'. And they introduce all of the disadvantages
listed there, especially this one, listed first:
[I]f you change the definition of the function, calls already
inlined still use the old definition until you recompile them.
One use case: I have highlighting code that uses text property
`font-lock-ignore'. I modify a few font-lock.el functions so that text
that has this property is ignored. IOW, this property tells font-lock
"Hands off", so that it will not erase of otherwise interfere with such
highlighting.
I see no reason why these function should not be defuns.
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
of 2013-02-17 on VBOX-W7
Bzr revision: 111822 rgm@gnu.org-20130217190146-mm9bh3227ev56bus
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
`configure --with-gcc (4.7) --no-opt --enable-checking --cflags
-IC:/emacs/libs/libXpm-3.5.10/include -IC:/emacs/libs/libXpm-3.5.10/src
-IC:/emacs/libs/libpng-dev_1.4.3-1_win32/include
-IC:/emacs/libs/zlib-dev_1.2.5-2_win32/include
-IC:/emacs/libs/giflib-4.1.4-1-lib/include
-IC:/emacs/libs/jpeg-6b-4-lib/include
-IC:/emacs/libs/tiff-3.8.2-1-lib/include
-IC:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2
-IC:/emacs/libs/gnutls-3.1.8-w32/include
-IC:/emacs/libs/libiconv-1.14-2-mingw32-dev/include'
next reply other threads:[~2013-02-18 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 17:24 Drew Adams [this message]
2016-04-28 22:31 ` bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)' Lars Ingebrigtsen
2016-04-29 16:17 ` Drew Adams
2019-10-30 12:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220CC265C06944E69F89E1F29796C873@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=13764@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.